Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absent links, team member names should be centered under photos instead of left-justified #34

Closed
aaronsnow opened this issue Mar 22, 2014 · 3 comments

Comments

@aaronsnow
Copy link
Contributor

Names are left-justified under photos. Looks fine when there are also links under each name, but if it's just the names, maybe we should center them?

It's just .bio > h4 { text-align: center; width: 200px; } and then .bio > h4 { width: [75px | 120px | 225px]; } to match the image widths under each of the media queries.

(I'd fix and make a pull request, but I'm not sure which branch to start from ... can we consolidate from all the stray branches that are hanging out there now?)

image

@quepol
Copy link
Contributor

quepol commented Mar 25, 2014

I'm inclined to leave it since Lena says we'll be adding back in github and potential bios soon. But regarding which branch, I don't know. launch-no-links was it, but it hasn't been merged, so I don't know exactly what happened.

@NoahKunin
Copy link
Contributor

Yeah, seems like the branches got a bit messy.

I say we clear out the underbrush [merge or die by the end of the week] and then just create a clean new branch called links-back.

@quepol quepol added the wontfix label Apr 25, 2014
@quepol
Copy link
Contributor

quepol commented Apr 25, 2014

I think we're close to pushing links again. Closing this.

@quepol quepol closed this as completed Apr 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants