Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policies in the footer and the linking policy #40

Closed
NoahKunin opened this issue Apr 7, 2014 · 17 comments
Closed

Policies in the footer and the linking policy #40

NoahKunin opened this issue Apr 7, 2014 · 17 comments

Comments

@NoahKunin
Copy link
Contributor

Right now our reference to the Privacy policy is in the content near the signup.

If we move this and our future Linking Policy into the footer, we can just set it and forget it.

Seems like we have room to the left of the Always Be Shipping image.

@quepol
Copy link
Contributor

quepol commented Apr 7, 2014

Easy. What branch to use?

I was deferring to Joe, but don't think he's got time to contribute so we need to (as per your earlier comment) merge and start clean.

@NoahKunin
Copy link
Contributor Author

Yup, I can do this on my own time. Let's let the other PR go through first.

@NoahKunin
Copy link
Contributor Author

Potential text for linking policy here: https://github.com/18F/18f.gsa.gov/blob/linking-policy/linking-policy.md

@quepol
Copy link
Contributor

quepol commented Apr 11, 2014

👍 I say get John's eyes on it and :shipit:

@NoahKunin
Copy link
Contributor Author

Roger, cc @jpyuda

Sorry design isn't ready yet, doing this on my own time and Heartbleed killed what little time I had. Things are calming down so circling back

@quepol
Copy link
Contributor

quepol commented Apr 13, 2014

Sorry, I meant get John Peters in OGC's eyes on the policy. Not @jpyuda's eyes on your design. :)

@NoahKunin
Copy link
Contributor Author

Ah, ok, that makes more sense now. Yep, that is a gate before this change.

On Sun, Apr 13, 2014 at 12:06 AM, Hillary Hartley
notifications@github.comwrote:

Sorry, I meant get John Peters in OGC's eyes on the policy. Not @jpyudahttps://github.com/jpyuda's
eyes on your design. :)

Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-40299103
.

Noah Kunin | @NoahKunin http://twitter.com/noahkunin |
@18fhttps://twitter.com/18F

@jpyuda
Copy link
Member

jpyuda commented Apr 14, 2014

(That said, it looks fine to me. ;)

@NoahKunin
Copy link
Contributor Author

It's with JP

@NoahKunin
Copy link
Contributor Author

...who is out of the office until the 21st.

@NoahKunin
Copy link
Contributor Author

Legal got back to us. Updated text posted:

https://github.com/18F/18f.gsa.gov/blob/linking-policy/linking-policy.md

@quepol
Copy link
Contributor

quepol commented Apr 25, 2014

Awesome. Can this be integrated with Jekyll, too? So that if there are other chunks of text we need to write, we can manage .md files? I agree that the subpage template for now can be very similar to "thank-you.html".

@jpyuda
Copy link
Member

jpyuda commented Apr 25, 2014

Yes, absolutely.

Is this ready to use (in lieu of the popup?) Or is there more wrangling that has to happen first?

@NoahKunin
Copy link
Contributor Author

Yup, ready to rock and roll. Just had it in a solo md file for collaboration. Was going to let the Jekyll PR through first then wrangle this branch in after.

@jpyuda
Copy link
Member

jpyuda commented Apr 25, 2014

I'll branch off of the jekyll branch locally and pull this in for a merge, unless you're dying to do it.

@NoahKunin
Copy link
Contributor Author

Not at all, please go for it! Again, just to make sure we're on the same page, it's just the MD static copy. I hadn't made any mods to the footer yet.

@quepol
Copy link
Contributor

quepol commented Apr 30, 2014

Closing this. Can open a new Jekyll story, if needed/wanted.

@quepol quepol closed this as completed Apr 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants