-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policies in the footer and the linking policy #40
Comments
Easy. What branch to use? I was deferring to Joe, but don't think he's got time to contribute so we need to (as per your earlier comment) merge and start clean. |
Yup, I can do this on my own time. Let's let the other PR go through first. |
Potential text for linking policy here: https://github.com/18F/18f.gsa.gov/blob/linking-policy/linking-policy.md |
👍 I say get John's eyes on it and |
Roger, cc @jpyuda Sorry design isn't ready yet, doing this on my own time and Heartbleed killed what little time I had. Things are calming down so circling back |
Sorry, I meant get John Peters in OGC's eyes on the policy. Not @jpyuda's eyes on your design. :) |
Ah, ok, that makes more sense now. Yep, that is a gate before this change. On Sun, Apr 13, 2014 at 12:06 AM, Hillary Hartley
Noah Kunin | @NoahKunin http://twitter.com/noahkunin | |
(That said, it looks fine to me. ;) |
It's with JP |
...who is out of the office until the 21st. |
Legal got back to us. Updated text posted: https://github.com/18F/18f.gsa.gov/blob/linking-policy/linking-policy.md |
Awesome. Can this be integrated with Jekyll, too? So that if there are other chunks of text we need to write, we can manage .md files? I agree that the subpage template for now can be very similar to "thank-you.html". |
Yes, absolutely. Is this ready to use (in lieu of the popup?) Or is there more wrangling that has to happen first? |
Yup, ready to rock and roll. Just had it in a solo md file for collaboration. Was going to let the Jekyll PR through first then wrangle this branch in after. |
I'll branch off of the jekyll branch locally and pull this in for a merge, unless you're dying to do it. |
Not at all, please go for it! Again, just to make sure we're on the same page, it's just the MD static copy. I hadn't made any mods to the footer yet. |
Closing this. Can open a new Jekyll story, if needed/wanted. |
Right now our reference to the Privacy policy is in the content near the signup.
If we move this and our future Linking Policy into the footer, we can just set it and forget it.
Seems like we have room to the left of the Always Be Shipping image.
The text was updated successfully, but these errors were encountered: