font rendering not working due to .hasOwnProperty("cssRules") returning false

[borkdude]

Use case: description, code

I was trying out the latest code from master to get font-awesome rendering fixed. This still didn't work.

Expected behavior

Font awesome fonts are rendered.

Actual behavior (stack traces, console logs etc)

When I execute this in the console:

document.styleSheets[1].hasOwnProperty("cssRules")

I saw that it returned false while it's actually a valid styleSheet object with a cssRules property:

The relevant line in the code:

dom-to-image-more/src/dom-to-image-more.js

Line 733 in d3ee842

if (sheet.hasOwnProperty("cssRules")) {

does this check and that's the reason why no stylesheets are actually embedded.

I believe this check can be omitted anyway because of the try catch that follows?

Library version

Master @ commit d3ee842

Browsers

• Chrome 78.0.3904.70 (Official Build) (64-bit)
• Firefox 70.0.1 (64-bit)

[jaredleishman]

Experiencing this same issue. Removing the if block fixed it for me. Meaning, the fonts were pulled in correctly. With that said, I am still getting errors in the console from the try catch block and it is noticeably slower.

[devsalsa]

if (sheet.hasOwnProperty("cssRules")) { should probably be Object.getPrototypeOf(sheet).hasOwnProperty("cssRules")

[IDisposable]

I've updated master for this change, will cut a release soon

[IDisposable]

Hey @borkdude , @jaredleishman ... is this working for you in v2.9.5?