Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: update Java version and update/remove dependencies #4

Merged
merged 8 commits into from
Oct 27, 2022

Conversation

DCKcode
Copy link
Collaborator

@DCKcode DCKcode commented Oct 27, 2022

I'm using this PR to merge a few maintenance tasks. What this MR does:

  • Updates the Java version from the unsupported 15 to Java 17 LTS, where it can stay unchanged for longer. Updates are in the readme as well as the GitHub Action that builds a release.
  • Do some plumbing in Gradle to use the latest version there also.
  • Updates the few dependencies we have to the latest version.
  • Removes a dependency I used for a functional programming construct that I replaced with a home made utility class.

These changes are all lightly intertwined so I figured I'd bundle them in a single PR .

Copy link

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. My only nit is that the if( spacing is inconsistent with other places that use if (. I only left one comment but it happens in quite a few places visible in the diff.

@DCKcode DCKcode merged commit d21161a into main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants