Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance and fixes for release action #5

Merged
merged 6 commits into from Oct 28, 2022
Merged

Maintenance and fixes for release action #5

merged 6 commits into from Oct 28, 2022

Conversation

DCKcode
Copy link
Collaborator

@DCKcode DCKcode commented Oct 28, 2022 •
edited

I noticed two issues with the release action in this repository

  • The method to build a jar with all dependencies wasn't working after the Gradle 7 migration, breaking the release artifacts
  • The release action used GitHub actions that threw deprecation warnings
  • We were still on an old version of the Gradle wrapper which made builds slightly slower and noisy

This PR addresses all.

AB1Pass
AB1Pass approved these changes Oct 28, 2022
View reviewed changes
Copy link

@AB1Pass AB1Pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

AB1Pass
AB1Pass approved these changes Oct 28, 2022
View reviewed changes
Copy link

@AB1Pass AB1Pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok.

@DCKcode DCKcode merged commit 442514a into main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AB1Pass AB1Pass AB1Pass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DCKcode @AB1Pass