update example so Users view listens to changes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thought it might be helpful if the example WithSwiftUI was extended a bit as I'm learning more about Ballcap. There is one issue that still needs fixing though, and I'd love your thoughts on best way to fix:
If you tap on a user and edit their name, after clicking save UserView correctly shows the updates. The app running on a separate iPhone in the Users (ContentView) or UserView will also show the updates correctly. However, if on the iPhone where the edit was made you go back to the Users list, the list still shows the previous state of the name property, prior to the edit. I'll look at the code more closely, but if you had any thoughts on your preferred way to fix this bug, please let me know.
Thank you for your effort to code up such a nice library.
Kimon