ndcli: list pool filter by layer3domain #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add layer3domain filter to `ndcli list pools` like there's for `list containers` already
Srudush
reviewed
Jan 31, 2022
Add `layer3domain` to the default list of attributes to output for `ndcli list pools`, as well as `ippool_list()` in DIM. Updated tests accordingly.
|
Nice work :D Thank you! |
zeromind
added a commit
to zeromind/dim
that referenced
this pull request
Feb 8, 2022
expose layer3domain as parameter for `ippool_count()` and pass it on this makes the function work again, after it broke with ionos-cloud#193, also allows filtering by layer3domain now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add layer3domain filter to
ndcli list poolslike there's forlist containersalreadyresolves #121