Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing animations #93

Open
ansverr opened this issue May 3, 2024 · 3 comments
Open

Missing animations #93

ansverr opened this issue May 3, 2024 · 3 comments

Comments

@ansverr
Copy link

ansverr commented May 3, 2024

I've had two separate crashes that both referred to missing animations.

The missing animations in question were:
ANIMS\S_MERC\S_DIEFWD.STI
ANIMS\M_MERC\M_DIEFWD.STI

Both crashes happened when killing an enemy in tactical battle.

I see the animations are mentioned in the source code, Animation Data.cpp, but I can't seem to find the animation files anywhere.

I'm playing the Steam version of JA2 with the latest unstable version of 1.13, v1-146-gc32d09b.

@kitty624
Copy link
Contributor

kitty624 commented May 4, 2024

Those are inside subdirectories of Anims.slf

The .slf are part of the original JA2
Animations in question are for "falling forward" (hence the FWD in name). Merc is slowly falling first to knees then to ground

So, they ain't missing.
But, iirc, it isn't the first time that specifically those seem to cause issues (I recall simular reports on discord)

Just, whatever the issue might be, the reason is not them missing.
If you could provide a save and description how to reliable reproduce the crash, that might could prove helpfull to track it down

@kitty624
Copy link
Contributor

kitty624 commented May 4, 2024

Anim_Merc_Die_Falling_Forward.zip

I unpacked them from the .slf
You can try to place them into Data/Anims/S_MERC and Data/Anims/M_MERC

No guarantee, but might worth a try to further narrow down the issue

@ansverr
Copy link
Author

ansverr commented May 5, 2024

Thanks for the explanation. I have a better understanding of what to look for now. After a little bit of testing it's clear that the animations work under normal circumstances, both with and without the loose files you provided. Fortunately, the crash is very rare, but it's hard to reproduce. In tens of hours of gameplay I've had it happen twice. If I run into it again I'll do some more focused testing and hopefully I can narrow it down a little more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants