Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate test harness off deprecated XPCOM interfaces #189

Open
1ec5 opened this issue Dec 27, 2017 · 0 comments
Open

Migrate test harness off deprecated XPCOM interfaces #189

1ec5 opened this issue Dec 27, 2017 · 0 comments

Comments

@1ec5
Copy link
Owner

1ec5 commented Dec 27, 2017

The in-application test harness uses a variety of XPCOM interfaces that have been removed:

  • nsIAtomService, which was removed for bug 1,393,692, to format table cells:

    avim/content/test/tester.js

    Lines 272 to 274 in 9a84083

    const iface = Components.interfaces.nsIAtomService;
    let atomService = Components.classes["@mozilla.org/atom-service;1"]
    .getService(iface);

  • nsIFilePicker.show(), removed in favor of nsIFilePicker.open():

    // https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIFilePicker
    let fp = Cc["@mozilla.org/filepicker;1"]
    .createInstance(Ci.nsIFilePicker);
    fp.init(window, "Choose Input File", Ci.nsIFilePicker.modeOpenMultiple);
    fp.appendFilters(Ci.nsIFilePicker.filterText);
    let rv = fp.show();

  • nsILocalFile, which was removed in favor of nsIFile:

    let file = files.getNext().QueryInterface(Ci.nsILocalFile);

@1ec5 1ec5 changed the title Migrate test harness off nsIAtomService Migrate test harness off deprecated interfaces Dec 27, 2017
@1ec5 1ec5 changed the title Migrate test harness off deprecated interfaces Migrate test harness off deprecated XPCOM interfaces Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant