-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable react components? #105
Comments
@nicholaszuccarelli I just pushed a new version making the react component optional ( Try this and let me know how it goes: https://github.com/1egoman/funnies#javascript |
Awesome I'll give it a try later! Thanks :) |
Hey man, one more problem when installing. It won't actually install now because it is still looking for the react dependency when running npm install --save funnies |
React is still a peer dependency (read more), but I don't really see a way around that without separating the react code into a separate package. Can I take a look at some logs? I suspect you're just getting a warning about the peer dependency being missing (and while it's still something to address, a missing peer dependency shouldn't block installation of a package) |
Inside of your |
Yeah, it looks like it did indeed add the files but for some reason the build corrupt. |
Cool, good to hear! If you end up writing a nice Vue wrapper for funnies consider contributing it back to the project! 😄 |
I am using VueJS and it is complaining that it cannot resolve "React".
Is there any way to make it pick a random message string without trying to use react?
Thanks
The text was updated successfully, but these errors were encountered: