Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable react components? #105

Closed
nicholaszuccarelli opened this issue Nov 8, 2017 · 8 comments
Closed

Disable react components? #105

nicholaszuccarelli opened this issue Nov 8, 2017 · 8 comments

Comments

@nicholaszuccarelli
Copy link

I am using VueJS and it is complaining that it cannot resolve "React".

Is there any way to make it pick a random message string without trying to use react?

Thanks

@1egoman
Copy link
Owner

1egoman commented Nov 8, 2017

@nicholaszuccarelli I just pushed a new version making the react component optional (v2.0.0)

Try this and let me know how it goes: https://github.com/1egoman/funnies#javascript

@nicholaszuccarelli
Copy link
Author

Awesome I'll give it a try later! Thanks :)

@nicholaszuccarelli
Copy link
Author

Hey man, one more problem when installing. It won't actually install now because it is still looking for the react dependency when running npm install --save funnies

@1egoman
Copy link
Owner

1egoman commented Nov 10, 2017

React is still a peer dependency (read more), but I don't really see a way around that without separating the react code into a separate package.

Can I take a look at some logs? I suspect you're just getting a warning about the peer dependency being missing (and while it's still something to address, a missing peer dependency shouldn't block installation of a package)

@nicholaszuccarelli
Copy link
Author

For some reason it is blocking the installation. When I import funnies into the component file, it just complains that funnies doesn't exist.

image

@1egoman
Copy link
Owner

1egoman commented Nov 10, 2017

Inside of your node_modules folder, do you have a funnies folder? In the above, it looks like the installation succeeded, but your build script failed. (Trying to figure out if it's something weird with funnies or something weird with the build script)

@nicholaszuccarelli
Copy link
Author

Yeah, it looks like it did indeed add the files but for some reason the build corrupt.
I deleted the folder and reinstalled and it works now! Thanks a lot (great package btw :P)

@1egoman
Copy link
Owner

1egoman commented Nov 10, 2017

Cool, good to hear! If you end up writing a nice Vue wrapper for funnies consider contributing it back to the project! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants