Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Apps which can open links" list is incomplete. #36

Closed
pressRtowin opened this issue Mar 14, 2023 · 38 comments
Closed

"Apps which can open links" list is incomplete. #36

pressRtowin opened this issue Mar 14, 2023 · 38 comments
Assignees

Comments

@pressRtowin
Copy link
Contributor

On my device, it only shows 105 apps. The system "Apps that can open links" page in settings shows 203. Though that page does include apps I have installed on all 4 profiles (Main/Dual/Work/Secure) those apps alone are nowhere near enough to make up for the almost 100 app difference.

Also some of the app names and icons are wonky, and the list is sorted A-Z,a-z rather than A/a-Z/z so "eBay" is listed last for instance.

1fexd added a commit that referenced this issue Mar 14, 2023
@1fexd
Copy link
Collaborator

1fexd commented Mar 14, 2023

I can't reproduce the first issue since I don't have a secondary profile, but I guess the issue is that LinkSheet only shows apps from your main profile which have a launcher activity (i.e. it shows up as an app in your app drawer).

I have fixed the sorting issue.

@1fexd 1fexd self-assigned this Mar 14, 2023
@pressRtowin
Copy link
Contributor Author

those apps alone are nowhere near enough to make up for the almost 100 app difference.

I do not have 100 apps in other profiles. These are apps on my main profile that are missing.

@pressRtowin
Copy link
Contributor Author

pressRtowin commented Mar 14, 2023

Screenshot_20230314_153141_Settings

Screenshot_20230314_153345_LinkSheet

@1fexd
Copy link
Collaborator

1fexd commented Mar 17, 2023

Strange, Gmail and FedEx show up for me (FV File Explorer and F-Droid won't, since they have no verified app links). If I sent you a debug build, would you be able to do a logcat?

@pressRtowin
Copy link
Contributor Author

pressRtowin commented Mar 17, 2023

Yeah should be able to. A bit off topic but what's everyone using for logcat viewers these days? I've been using this one tool forever that hasn't been updated in 5 years lol. Anything good out there?

Wouldn't mind sending you a complete list of the apps in my system links menu either if that'd help.

@1fexd
Copy link
Collaborator

1fexd commented Mar 17, 2023

I don't know of any tools, I just use adb; Do you have access to a PC with adb?

@pressRtowin
Copy link
Contributor Author

No PC access at the moment but I have LADB set up

@1fexd
Copy link
Collaborator

1fexd commented Mar 17, 2023

Okay, I have uploaded a debug build here: 0.0.28-debug. This app installs next to the release build, so you will need to set it as default browser.

To get the logcat, first execute adb shell pidof -s fe.linksheet.debug which yields the process id of the app, then run adb logcat --pid=YOUR_PID_HERE. After that, open the "Apps which can open links" settings page, which should print lots of lines containing D InstalledPackage:. Find the ones of the apps you don't see on the settings page, then check what it says after the second :. If it says null, the package could somehow not be resolved/or it has no user-facing app. If there is no line for the apps you are missing, the package could (for some reason) not be found.

Example line where the app is resolved correctly:

03-17 16:20:13.950 29807 31366 D InstalledPackage: com.google.android.GoogleCamera: ResolveInfo{81be52a com.google.android.GoogleCamera/com.android.camera.CameraLauncher m=0x108000}

Example line where it isn't / there is no user-facing app:

03-17 16:20:13.953 29807 31366 D InstalledPackage: com.google.android.inputmethod.latin: null

@pressRtowin
Copy link
Contributor Author

I'm still going through and checking apps (LADB did NOT like loading that many lines 😅) but I can confirm that FedEx and Gmail appear in the debug version and not the current released version.

@pressRtowin
Copy link
Contributor Author

Wait, no FedEx WAS in the other version, but listed under the Ls as "Login" 😂

@pressRtowin
Copy link
Contributor Author

What I'm not understanding is what determines which apps appear in the system "Apps that can open links" menu? There's a mix of apps with app links and apps without in there, but there's also plenty of apps without links NOT in that menu as well.

Also, like you said, FV File Explorer and F-Droid both don't have links (despite being in the system menu) so they don't show up in LinkSheet, however neither does Archero, which also shows up in the system menu AND in LinkSheet:

Screenshot_20230317_112203_LinkSheet Debug

D InstalledPackage: org.fdroid.fdroid: ResolveInfo{77cfb39 org.fdroid.fdroid/.views.main.MainActivity m=0x108000}
D InstalledPackage: com.habby.archero: ResolveInfo{e861804 com.habby.archero/.UnityPlayerActivity m=0x108000}

@pressRtowin
Copy link
Contributor Author

Wait, I'm stupid. The "Supported web addresses" link is always grayed out when "Open supported links" is disabled. Archero does have one. Still doesn't explain why apps like FedEx and FV are in the system menu.

@1fexd
Copy link
Collaborator

1fexd commented Mar 17, 2023

Have you checked the Enabled tab?

@pressRtowin
Copy link
Contributor Author

pressRtowin commented Mar 17, 2023

Enabled is empty. One of the first things I do on every device after installing apps is manually going through the system menu and disabling Open supported links on all of them (regardless of if they have links listed or not), and I haven't installed much else besides LinkSheet lately, so I've never seen any apps listed under enabled yet.

If it says null, the package could somehow not be resolved/or it has no user-facing app.

I see a potential problem here. Both com.samsung.android.mobileservice and com.samsung.android.mateagent show up as null (and therefore aren't listed in LinkSheet), and I suspect this is due to them not having user-facing apps. However they are both able to handle links and each have a few listed under Supported web addresses.

@pressRtowin
Copy link
Contributor Author

pressRtowin commented Mar 17, 2023

Interestingly, com.samsung.android.mobileservice is shown in 0.0.22, as you can see in the screenshot above, but in the debug version, it's gone.

@1fexd
Copy link
Collaborator

1fexd commented Mar 17, 2023

I see a potential problem here. Both com.samsung.android.mobileservice and com.samsung.android.mateagent show up as null (and therefore aren't listed in LinkSheet), and I suspect this is due to them not having user-facing apps. However they are both able to handle links and each have a few listed under Supported web addresses.

Damn, I didn't take that into account.

Interestingly, com.samsung.android.mobileservice is shown in 0.0.22, as you can see in the screenshot above, but in the debug version, it's gone.

Yep, I changed the behavior in 0.0.23. The strange thing is that I actually added a fallback to the old version, should an app not have a user-facing launcher

@pressRtowin
Copy link
Contributor Author

Does Open supported links do anything for apps that have nothing listed under Supported web addresses? There has to be a reason some of those apps are listed under Apps that can open links while others aren't, right?

@1fexd
Copy link
Collaborator

1fexd commented Mar 19, 2023

No, that shouldn't do anything

@pressRtowin
Copy link
Contributor Author

Very strange. Maybe a One UI bug? Do FV or F-Droid show up in the system menu on your phone?

@1fexd
Copy link
Collaborator

1fexd commented Mar 19, 2023

Yes, FV and F-Droid show up in the system menu on my phone, but not in LinkSheet (expected behavior since FV does not have any links, while F-Droid has some but they must be selected by the user). I am not quite sure how to fix this, I think it may be a OneUI bug since it works flawlessly on stock android.

@pressRtowin
Copy link
Contributor Author

I'm confused. Are you on stock? If FV (with no links) is showing up on your system menu, then isn't stock having the same issue?

Also, do you mean that the links for F-Droid are not enabled by default but the user is able to select them from the system menu? If that is the case, shouldn't F-Droid still show up in LinkSheet (under disabled by default), in case it was enabled at some point?

@1fexd
Copy link
Collaborator

1fexd commented Mar 19, 2023

I'm confused. Are you on stock? If FV (with no links) is showing up on your system menu, then isn't stock having the same issue?

Isn't the issue that Gmail and those Samsung apps do not show up in LinkSheet?

Also, do you mean that the links for F-Droid are not enabled by default but the user is able to select them from the system menu? If that is the case, shouldn't F-Droid still show up in LinkSheet (under disabled by default), in case it was enabled at some point?

Yes, I have fixed this.

@pressRtowin
Copy link
Contributor Author

pressRtowin commented Mar 19, 2023

Isn't the issue that Gmail and those Samsung apps do not show up in LinkSheet?

I was referring to the issue of apps with no links appearing in the system menu. There
must be some logic (whether buggy or not) that determines which apps go in that menu (and why some apps without links are there).

As for the discrepancy with LinkSheet, as far as I can tell, that's entirely due to apps like F-Droid (now fixed) and apps with no UI now. Gmail was in there, just sorted somewhere completely different due to the name issuue.

@1fexd
Copy link
Collaborator

1fexd commented Mar 19, 2023

apps with no UI now

Stange, this still shouldn't happen. Will check again

@pressRtowin
Copy link
Contributor Author

That was those two Samsung apps. I'm still checking if there's others.

@pressRtowin
Copy link
Contributor Author

pressRtowin commented Mar 20, 2023

Found the following apps in the system menu which also don't appear in LinkSheet (and have links that are not user-selectable):

  • Google Play Services
  • Link to Windows
  • Meta App Manager
  • Quick share
  • Samsung accounts
  • Samsung wallet digital key

There are also some more packages with no user-facing apps that do have user-selectable links like Google Play Services for AR.

Also, interestingly enough, LinkSheet (both stable and debug) is one of those apps that show up in the system menu despite not having any supported links at all.

@pressRtowin
Copy link
Contributor Author

pressRtowin commented Mar 20, 2023

Just installed 0.0.29 and quite a few apps with user selectable links (and some with both) are still not shown, in addition to the apps mentioned in previous comments. These include:

  • com.authy.authy
  • com.joaomgcd.autoshare
  • com.joaomgcd.autotools
  • com.cardpointers.app
  • com.samsung.android.themestore
  • com.samsung.android.gts
  • com.lifx.lifx
  • com.microsoft.appmanager
  • com.google.audio.hearing.visualization.accessibility.scribe
  • org.schabi.newpipe
  • net.ssens.headsupa
  • com.samsung.android.app.sharelive
  • com.vanced.android.youtube/app.revanced.android.youtube/app.rvx.android.youtube
  • nl.fameit.rotate
  • com.samsung.android.app.spage
  • com.sec.android.app.shealth
  • com.samsung.android.shealthmonitor
  • com.samsung.android.tvplus
  • com.samsung.android.fast
  • org.telegram.messenger
  • org.thunderdog.challegram
  • com.ss.android.ugc.trill (but com.zhiliaoapp.musically does show up)
  • com.tmobile.tuesdays
  • com.ups.mobile.android
  • com.vanced.manager
  • us.zoom.videomeetings

@1fexd
Copy link
Collaborator

1fexd commented Mar 21, 2023

Just installed 0.0.29 and quite a few apps with user selectable links (and some with both) are still not shown, in addition to the apps mentioned in previous comments. These include:

* `com.authy.authy`

* `com.joaomgcd.autoshare`

* `com.joaomgcd.autotools`

* `com.cardpointers.app`

* `com.samsung.android.themestore`

* `com.samsung.android.gts`

* `com.lifx.lifx`

* `com.microsoft.appmanager`

* `com.google.audio.hearing.visualization.accessibility.scribe`

* `org.schabi.newpipe`

* `net.ssens.headsupa`

* `com.samsung.android.app.sharelive`

* `com.vanced.android.youtube`/`app.revanced.android.youtube`/`app.rvx.android.youtube`

* `nl.fameit.rotate`

* `com.samsung.android.app.spage`

* `com.sec.android.app.shealth`

* `com.samsung.android.shealthmonitor`

* `com.samsung.android.tvplus`

* `com.samsung.android.fast`

* `org.telegram.messenger`

* `org.thunderdog.challegram`

* `com.ss.android.ugc.trill` (but `com.zhiliaoapp.musically` does show up)

* `com.tmobile.tuesdays`

* `com.ups.mobile.android`

* `com.vanced.manager`

* `us.zoom.videomeetings`

At the moment, apps with user selectable links will only show up if at least one of the links has been selected by the user.

@1fexd
Copy link
Collaborator

1fexd commented Mar 21, 2023

Found the following apps in the system menu which also don't appear in LinkSheet (and have links that are not user-selectable):

* Google Play Services

* Link to Windows

* Meta App Manager

* Quick share

* Samsung accounts

* Samsung wallet digital key

There are also some more packages with no user-facing apps that do have user-selectable links like Google Play Services for AR.

Also, interestingly enough, LinkSheet (both stable and debug) is one of those apps that show up in the system menu despite not having any supported links at all.

Will look into that.

@1fexd 1fexd added todo and removed needs feedback labels Mar 21, 2023
@1fexd
Copy link
Collaborator

1fexd commented Mar 28, 2023

Very strange, I just tested Link to Windows and it shows up just fine in LinkSheet

@1fexd 1fexd added needs feedback and removed todo labels Mar 28, 2023
@pressRtowin
Copy link
Contributor Author

Doesn't show up for me. It has two supported links. One is user selectable, the other isn't. Toggling the user selectable one had no impact.

@1fexd
Copy link
Collaborator

1fexd commented Jun 7, 2023

Sorry for getting back to you this late, does this issue still persist on the latest nightly build?

@pressRtowin
Copy link
Contributor Author

Based on a quick count, yes. Both this and the current release show the same number of apps. I didn't check every app one by one because for some reason, all the apps are out of order in the nightly (YouTube was second on the list lol). It seems the spacing was also changed? Went from about 19 apps per page to 17.

@1fexd
Copy link
Collaborator

1fexd commented Jun 7, 2023

I didn't check every app one by one because for some reason, all the apps are out of order in the nightly (YouTube was second on the list lol)

Fixed.

It seems the spacing was also changed? Went from about 19 apps per page to 17.

Yes, but that's probably going to change again.

I am starting to think this is some sort of bug in OneUI? Everything works fine here on my Pixel. Wouldn't be the first time I had to specifically work around Samsung's buggy software lol

@pressRtowin
Copy link
Contributor Author

Also was it intended that the share sheet's show package name setting also affects the "apps which can open links" list?

A bit unrelated, but there could be some further clarity on the "use unified settings" option (and the two buttons under it). Played around with it for 10 min and could not figure out what it does lol

@1fexd
Copy link
Collaborator

1fexd commented Jun 7, 2023

Also was it intended that the share sheet's show package name setting also affects the "apps which can open links" list?

Yes, gonna move the switch somewhere else, thanks for pointing that out.

A bit unrelated, but there could be some further clarity on the "use unified settings" option (and the two buttons under it). Played around with it for 10 min and could not figure out what it does lol

Will do.

@1fexd
Copy link
Collaborator

1fexd commented Jul 30, 2023

Alright, the "Use unified settings" toggle has a clear description now. Switch will be moved somewhere else in 1.0.0 (see #140), marked with a disclaimer for now.

@1fexd 1fexd closed this as completed Jul 30, 2023
@1fexd
Copy link
Collaborator

1fexd commented Jul 30, 2023

If there's still anything left to fix, please open a new issue. This one's getting quite long and is filled with unrelated stuff. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants