-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Apps which can open links" list is incomplete. #36
Comments
I can't reproduce the first issue since I don't have a secondary profile, but I guess the issue is that LinkSheet only shows apps from your main profile which have a launcher activity (i.e. it shows up as an app in your app drawer). I have fixed the sorting issue. |
I do not have 100 apps in other profiles. These are apps on my main profile that are missing. |
Strange, Gmail and FedEx show up for me (FV File Explorer and F-Droid won't, since they have no verified app links). If I sent you a debug build, would you be able to do a logcat? |
Yeah should be able to. A bit off topic but what's everyone using for logcat viewers these days? I've been using this one tool forever that hasn't been updated in 5 years lol. Anything good out there? Wouldn't mind sending you a complete list of the apps in my system links menu either if that'd help. |
I don't know of any tools, I just use |
No PC access at the moment but I have LADB set up |
Okay, I have uploaded a debug build here: 0.0.28-debug. This app installs next to the release build, so you will need to set it as default browser. To get the logcat, first execute Example line where the app is resolved correctly:
Example line where it isn't / there is no user-facing app:
|
I'm still going through and checking apps (LADB did NOT like loading that many lines 😅) but I can confirm that FedEx and Gmail appear in the debug version and not the current released version. |
Wait, no FedEx WAS in the other version, but listed under the Ls as "Login" 😂 |
What I'm not understanding is what determines which apps appear in the system "Apps that can open links" menu? There's a mix of apps with app links and apps without in there, but there's also plenty of apps without links NOT in that menu as well. Also, like you said, FV File Explorer and F-Droid both don't have links (despite being in the system menu) so they don't show up in LinkSheet, however neither does Archero, which also shows up in the system menu AND in LinkSheet:
|
Wait, I'm stupid. The "Supported web addresses" link is always grayed out when "Open supported links" is disabled. Archero does have one. Still doesn't explain why apps like FedEx and FV are in the system menu. |
Have you checked the |
I see a potential problem here. Both |
Interestingly, |
Damn, I didn't take that into account.
Yep, I changed the behavior in |
Does |
No, that shouldn't do anything |
Very strange. Maybe a One UI bug? Do FV or F-Droid show up in the system menu on your phone? |
Yes, FV and F-Droid show up in the system menu on my phone, but not in LinkSheet (expected behavior since FV does not have any links, while F-Droid has some but they must be selected by the user). I am not quite sure how to fix this, I think it may be a OneUI bug since it works flawlessly on stock android. |
I'm confused. Are you on stock? If FV (with no links) is showing up on your system menu, then isn't stock having the same issue? Also, do you mean that the links for F-Droid are not enabled by default but the user is able to select them from the system menu? If that is the case, shouldn't F-Droid still show up in LinkSheet (under disabled by default), in case it was enabled at some point? |
Isn't the issue that Gmail and those Samsung apps do not show up in LinkSheet?
Yes, I have fixed this. |
I was referring to the issue of apps with no links appearing in the system menu. There As for the discrepancy with LinkSheet, as far as I can tell, that's entirely due to apps like F-Droid (now fixed) and apps with no UI now. Gmail was in there, just sorted somewhere completely different due to the name issuue. |
Stange, this still shouldn't happen. Will check again |
That was those two Samsung apps. I'm still checking if there's others. |
Found the following apps in the system menu which also don't appear in LinkSheet (and have links that are not user-selectable):
There are also some more packages with no user-facing apps that do have user-selectable links like Google Play Services for AR. Also, interestingly enough, LinkSheet (both stable and debug) is one of those apps that show up in the system menu despite not having any supported links at all. |
Just installed 0.0.29 and quite a few apps with user selectable links (and some with both) are still not shown, in addition to the apps mentioned in previous comments. These include:
|
At the moment, apps with user selectable links will only show up if at least one of the links has been selected by the user. |
Will look into that. |
Very strange, I just tested |
Doesn't show up for me. It has two supported links. One is user selectable, the other isn't. Toggling the user selectable one had no impact. |
Sorry for getting back to you this late, does this issue still persist on the latest nightly build? |
Based on a quick count, yes. Both this and the current release show the same number of apps. I didn't check every app one by one because for some reason, all the apps are out of order in the nightly (YouTube was second on the list lol). It seems the spacing was also changed? Went from about 19 apps per page to 17. |
Fixed.
Yes, but that's probably going to change again. I am starting to think this is some sort of bug in OneUI? Everything works fine here on my Pixel. Wouldn't be the first time I had to specifically work around Samsung's buggy software lol |
Also was it intended that the share sheet's show package name setting also affects the "apps which can open links" list? A bit unrelated, but there could be some further clarity on the "use unified settings" option (and the two buttons under it). Played around with it for 10 min and could not figure out what it does lol |
Yes, gonna move the switch somewhere else, thanks for pointing that out.
Will do. |
Alright, the "Use unified settings" toggle has a clear description now. Switch will be moved somewhere else in 1.0.0 (see #140), marked with a disclaimer for now. |
If there's still anything left to fix, please open a new issue. This one's getting quite long and is filled with unrelated stuff. Thanks :) |
On my device, it only shows 105 apps. The system "Apps that can open links" page in settings shows 203. Though that page does include apps I have installed on all 4 profiles (Main/Dual/Work/Secure) those apps alone are nowhere near enough to make up for the almost 100 app difference.
Also some of the app names and icons are wonky, and the list is sorted A-Z,a-z rather than A/a-Z/z so "eBay" is listed last for instance.
The text was updated successfully, but these errors were encountered: