Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Suggestion] Resolve Google Amp links as regular links #58

Closed
GL513 opened this issue Apr 9, 2023 · 12 comments
Closed

[Feature Suggestion] Resolve Google Amp links as regular links #58

GL513 opened this issue Apr 9, 2023 · 12 comments
Assignees
Labels

Comments

@GL513
Copy link

GL513 commented Apr 9, 2023

Have a toggle to redirect the amp URLs to the normal webpages

@1fexd 1fexd self-assigned this Apr 25, 2023
@1fexd 1fexd added the todo label Apr 25, 2023
@TontyTon
Copy link

This would be very helpful.
Amputator Bot might be helpful to ease implement this feature.

@1fexd
Copy link
Collaborator

1fexd commented May 27, 2023

Is this really required? Every AMP link I have encountered while testing automatically redirects me to the full page.

@1fexd 1fexd added needs feedback and removed todo labels May 27, 2023
@GL513
Copy link
Author

GL513 commented May 27, 2023

It doesn't seem to work for me with Firefox nor Chrome

@1fexd
Copy link
Collaborator

1fexd commented May 27, 2023

Would you mind sharing the links?

@soymadip
Copy link

does an app even share AMP links?

@TontyTon
Copy link

@soymadip Other people send amp links, also some apps give amp links in References/More Reading sections.

@1fexd One amp link is https://historia.nationalgeographic.com.es/a/civilizacion-valle-indo-es-mas-antigua-que-egipcia-y-babilonica_6828/amp

I just searched for replies by amputator bot on reddit.
If you want more links, please ask me or check the messages to which AmputatorBot has replied to https://www.reddit.com/search/?q=amputator%20bot&type=comment

BTW, we want to convert amp links to normal links for several reasons, personally for me reasons are privacy and moral reasons. Detailed reasons can also be read at https://www.reddit.com/r/AmputatorBot/comments/ehrq3z/why_did_i_build_amputatorbot/ , 1st point.

@soymadip
Copy link

@soymadip Other people send amp links, also some apps give amp links in References/More Reading sections.

@1fexd One amp link is https://historia.nationalgeographic.com.es/a/civilizacion-valle-indo-es-mas-antigua-que-egipcia-y-babilonica_6828/amp

I just searched for replies by amputator bot on reddit.
If you want more links, please ask me or check the messages to which AmputatorBot has replied to https://www.reddit.com/search/?q=amputator%20bot&type=comment

BTW, we want to convert amp links to normal links for several reasons, personally for me reasons are privacy and moral reasons. Detailed reasons can also be read at https://www.reddit.com/r/AmputatorBot/comments/ehrq3z/why_did_i_build_amputatorbot/ , 1st point.

Hmm looks like there are then.

@TontyTon
Copy link

TontyTon commented Jun 9, 2023

Thanks for the feature.

I tried the latest nightly. It seems like it uses internet to unAMP (most of) the links.
Is it not possible to unAMP offline? As using online service involves a compromise to privacy.

@1fexd
Copy link
Collaborator

1fexd commented Jun 9, 2023

Doesn't seem to be possible, but why do you think it compromises your privacy? The website will get your IP nonetheless, and it probably also uses Google fonts or Analytics so Google will also track you, regardless of wheter you are using the AMP version of the page or not.

@TontyTon
Copy link

TontyTon commented Jun 9, 2023

Ohk, if it's not possible then okay, better than nothing, I would just suggest you to inform the user in the option's description that online connection will be made (for all or only amp links) and who will be contacted for that.
About privacy, I assumed you are using 3rd party service to unAMP the link. Am I wrong?
About google getting to know, if the link was unAMPed offline, then google won't know, I (and many others) block all of google, especially analytics.
Otherwise too it may be a issue, like sometimes one may choose to open some link in a browser with proxy, then user's IP can be leaked, that's why I suggested to inform the user (in first line of this comment).

@1fexd
Copy link
Collaborator

1fexd commented Jun 9, 2023

Ohk, if it's not possible then okay, better than nothing, I would just suggest you to inform the user in the option's description that online connection will be made (for all or only amp links) and who will be contacted for that.

Yep, will implement that.

About privacy, I assumed you are using 3rd party service to unAMP the link. Am I wrong?

By default the app resolved the AMP link locally, but the user can choose to use an API I have written and deployed to supabase (more info here)

@TontyTon
Copy link

TontyTon commented Jun 9, 2023

Ohkay. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants