-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links aren't getting opened in prefered app. #69
Comments
Your screenrecording appears to be broken. |
Oh, sorry for inconvenience Here's new one:- record.mp4
1.click on any link to open it |
Your video is still broken. I can't reproduce the bug by following your steps. |
What? Did you tried the steps below the video? So in your device if you select an app as 'always' for a link, it opens it automatically? |
I have tried your steps, but I wasn't able to reproduce the bug. It works fine for me. Can you try to re-upload the video? |
oh, sorry i should have been more clear😥.
Android 12 has 'open links in app' option to by default open a app's supported deep link in the app when the link is pressed. as example lets say for Github's mobile app, it supports https://github.com links. now if from popup, we select a app/browser to always open 'https://github.com' to that app by clicking always, thats where the bug is.
Lets say i have 1 browser and github mobile app's installed in my phone & i wanna open https://github.com/ links to the browser. now tap on 'https://github.com/' link from anywhere and linksheet opens Url-App-Chooser popup showing the browser and github mobile app. now long press the browser(in my case iceraven) and select the option 'alwa' from bottom-right corner. the link opens in browser. now close browser and again click om 'https://github.com' and linksheet shoud open the link automatically in browser right? i guess now the bug should be understandable |
new recording (it should work in PC):- tttWhatsApp.Video.2023-05-04.at.10.35.49.AM.mp4 |
Yeah, this problem is happening to me too. If we turn of the 'open links in app' which is mandatory if we wanna use this option:- And select some of the supported links' of an app, linksheet doesn't open the selected links automatically....... Linksheet doesn't open www.youtube.com links automatically in YouTube app. Is shows popup both for www.youtube.com (selected to automatically open) and m.youtube.com(not selected to automatically open in app) links. |
@1fexd please fix this |
@1fexd sorry to ping but i see you changed the label, so did you understand what i was sayiing?😅 |
Yes |
🙃finally. |
Just tested on the latest dev version, looks like this is not an issue anymore. Going to release a new version later. |
Thanks a lost sir, please release the fix version asap🙏 |
@1fexd the 'always' button is still not working, if we turn off 'open links in app' and use the linksheet popup to select a app/browser to always, it still again is displaying the app chooser sheet |
Very strange, still can't reproduce this. Gonna send you a debug build later. |
No pressure. Also if you want you can describe why it's not working on your PC and maybe I can tell you what's wrong. |
Please tell me🥲 |
how to generate log file? its showing logs in terminal though i copied the log and manually created a log.txt There's problem with the 'preferred app' thing i guess |
You need to click a link, not open the settings. |
I did go through the link opening after that.... |
I will record again tonight then |
there you go:- hope this one's good |
and i guess the pachage name would be fe.linksheet.debug(hope i wrote correct one cause in the comment it was fe.linkshet) |
I have attempted to fix the bug. You can download the new debug release here. Please check if it works, and if not, please provide another logcat. Thanks. |
I don't know if i was able to explain the problem correctly 😅 Please sir if you don't mind can you send me a screen record of you doing the process? I just wanna know if it's my phone's problem |
Just installed one of your old releases [V 0.0.21]. It is working in that version rtrtrtrtrtrt.mp4EDIT:- After trying all releases, i got that untill version 0.0.27-debug it's working and from 0.0.28-debug the feature is broken and no longer works.... logcat of that version;- |
In |
Ohhh I guess that's right. I didn't find the 'never show the last picked section' in earlier builds. I do use that feature as I find the 'last used app' section quite annoying |
I hope that's fixed. |
@soymadip Has your problem already been solved? I have the same problem when using linksheet with Revanced. If you have already solved your problem, what did you do to do it? What version of linksheet are you using now? |
Well @1fexd fixed it, but hasn't released it. But for now as a workover, disable the 'never show the last picked section'.. |
Thank you so much. I have disabled that option and a link to YouTube now opens directly in Revanced, (before, the link was opened first in the browser) But it works when I click a Youtube video link in Google search results, but not when I click a Youtube video link from Google Discover 🙄 @1fexd Can you fix it? |
|
Google discover is the news page when you swipe right in pixel devices.... |
And @Dhyfer1 it's designed to open links in Google app or Chrome custom tabs... As long as I know it cannot be changed |
I couldn't upload the video to my message because of its size, so you can see the video I'm talking about here And here is another video where if I click on a link to a youtube video in the search results, then the video does open in Revanced As you can see, my problem is similar to @soymadip. Is there anything that can be done about it? |
What happens if you install the normal Youtube app? Do Youtube links clicked in "Discover" automatically open in the normal Youtube app? If not, this is a issue with Chrome, not LinkSheet (looks like Chrome does not send a intent (which, in simple terms, is just a request to the Android system to open something in another app) when the link is clicked in Discover).
I plan to include an app-intro and a detailed setup guide in the next release. |
Hmm. The same thing happens with the normal YouTube app. If I click on a Youtube link from Discover, it just opens the video in a new tab, it's weird because within the settings for the YouTube app, the So it's a problem that only happens with YouTube links in Discover, but not with YouTube links in search results. Is it possible to force linksheet to open YouTube links from Discover in the YouTube or Revanced app? Could you test on your side if the same thing happens?
Great. I look forward to the new version soon. |
As already mentioned, LinkSheet is only started when an app explicitly sends an Intent to the system requesting that the content be opened in another app. Looks like Chrome doesn't do that when a link is clicked in Discover, so sadly, there's nothing I can do about that.
Btw, you are very welcome to test the nightly builds (new build on each commit) and report bugs ;) |
It's okay, I understand. No problem
Yes, thanks for the help. By the way, I hope the next stable version will have the app-intro and detailed setup you're talking about. ;) |
If we select an app for a link as 'always', the link isn't opening in prefered app. (If preferred browser is set as always ask)
Instead app shows all eligible apps again.
Screen record:-
Record_2023-04-26-20-41-08.mp4
The text was updated successfully, but these errors were encountered: