This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

wrong uint of the description of the skipPermitAndThresholdAmount #187

Open

lyciumlee opened this issue Dec 19, 2023 · 0 comments

lyciumlee commented Dec 19, 2023

the original text is

skipPermit is just 255'th byte of skipPermitAndThresholdAmount, when rest of bytes is thresholdAmount
See fillLimitOrder(), fillOrderToWithPermit() and packSkipPermitAndThresholdAmount() utils methods and helpers.

but I consider that the right texts are

skipPermit is just 255'th bit of skipPermitAndThresholdAmount, when rest of bytes is thresholdAmount
See fillLimitOrder(), fillOrderToWithPermit() and packSkipPermitAndThresholdAmount() utils methods and helpers.

convert the 'byte' to 'bit'

The text was updated successfully, but these errors were encountered:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.