Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game can freeze due to error when rewinding time all the way #3

Open
1j01 opened this issue Mar 23, 2024 · 0 comments
Open

Game can freeze due to error when rewinding time all the way #3

1j01 opened this issue Mar 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@1j01
Copy link
Owner

1j01 commented Mar 23, 2024

I'm not sure how to reproduce this exactly, but I've seen it crash the game loop when rewinding all the way. Obviously you need to drag some bricks around before rewinding to get this error:

Uncaught TypeError: brick.grabOffset is undefined
    updateDrag https://1j01.github.io/janitorial-android/src/game.js:3901
    render https://1j01.github.io/janitorial-android/src/game.js:5178
    animate https://1j01.github.io/janitorial-android/src/game.js:5561

Another error I got:

Uncaught TypeError: context.left is undefined
    nestedPatchFilter https://1j01.github.io/janitorial-android/lib/jsondiffpatch.umd.js:730
    process https://1j01.github.io/janitorial-android/lib/jsondiffpatch.umd.js:272
    process https://1j01.github.io/janitorial-android/lib/jsondiffpatch.umd.js:233
    patch https://1j01.github.io/janitorial-android/lib/jsondiffpatch.umd.js:3650
    unpatch https://1j01.github.io/janitorial-android/lib/jsondiffpatch.umd.js:3660
    handleRewind https://1j01.github.io/janitorial-android/src/game.js:4743
    animate https://1j01.github.io/janitorial-android/src/game.js:5535

I'm also seeing some general inconsistencies when rewinding, like bricks can end up floating in the air, as can Junkbot, who will then fall.

@1j01 1j01 added the bug Something isn't working label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant