Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konami Code isn't working on Firefox 59 #111

Closed
ptrcnull opened this issue Apr 17, 2018 · 6 comments
Closed

Konami Code isn't working on Firefox 59 #111

ptrcnull opened this issue Apr 17, 2018 · 6 comments

Comments

@ptrcnull
Copy link

It tries to search "ba" in the quick search box, so event listener doesn't record it,

@1j01
Copy link
Owner

1j01 commented Apr 18, 2018

It definitely works for me... what's the "quick search box"? Is that like a find-in-page thing or a search engine thing? Is it an extension?

@ptrcnull
Copy link
Author

ptrcnull commented Apr 18, 2018

It's an embedded Firefox feature to quickly find a word in a page, looks like this now:
search

@1j01
Copy link
Owner

1j01 commented Apr 18, 2018

Is this only on Linux, or is it an about:config flag?

Moreover, what do you think I should do about it?
I could add an option to the Extras menu that triggers the same effect, but it seems like I probably can't prevent-- well, okay, if it's doing that because the key events aren't prevented, I could edit the Konami Code detector and make it prevent a and b if and only if the pattern has been typed up until that point.

But basically, how do I get to this feature for testing?

@ptrcnull
Copy link
Author

ptrcnull commented Apr 18, 2018

I think it's enabled by default on Firefox 59.0.2 (64bit) on Windows.

EDIT: It does work when I add e.preventDefault() on keycodes 66 and 65.

@1j01
Copy link
Owner

1j01 commented Apr 18, 2018

Okay, it's an option in about:preferences (Options), "Search for text when you start typing"
(and accessibility.typeaheadfind in about:config)

I'll work on this now

@1j01 1j01 closed this as completed in d707733 Apr 18, 2018
@1j01
Copy link
Owner

1j01 commented Apr 18, 2018

Done! And btw these shortcuts are interesting. I've sorta been switching to Firefox since chrome is being a huge memory hog (with lots of tabs open, I should say!), and since Google removed down/up arrow keys support for navigating Google results, this seems like it would be a useful way to navigate them (').
I installed an extension to add the arrow keys functionality back in chrome, but this is a more general feature... I look forward to trying it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants