Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo history #40

Closed
akhmerov opened this issue Jan 18, 2018 · 3 comments
Closed

Undo history #40

akhmerov opened this issue Jan 18, 2018 · 3 comments

Comments

@akhmerov
Copy link

Great project!

I have however found one historically inaccurate bit: from what I remember, MS Paint didn't have undo history, limiting undo only to the last action. A quick search suggests it is indeed the case.

Perhaps jspaint should support a "historically precise" and "enhanced" modes?

@Airblader
Copy link

The README explicitly mentions that this version has unlimited undos as opposed to the original, so this is intended.

@1j01
Copy link
Owner

1j01 commented Jan 18, 2018

Yeah, I've considered having different modes for jspaint, but I'm not really interested in historical accuracy when it comes to arbitrarily limiting the user. I'd much rather work on historical accuracy of the efficiency of the undo history - because whilst mspaint limited the number of undos you could do drastically, it also stored them much more efficiently, whereas I naively store the entire image for every undo state.

If you just want historical accuracy, use an emulator! There's a nice online one here: https://copy.sh/v86/
It's got Windows 95 and Windows 98. (Of course you'd have to screenshot it to save images from it..)
(Windows 95, 98, and probably XP supported 3 undos. Basically none. 😄)

@1j01
Copy link
Owner

1j01 commented Jan 19, 2018

Closing this as I don't think it would be an improvement. I've opened #51 for efficiency.

@1j01 1j01 closed this as completed Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants