Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status code if condition in wisa.go needs to be updated to match with release requirements #4

Closed
tonyvugithub opened this issue Sep 22, 2020 · 0 comments · Fixed by #3
Closed

status code if condition in wisa.go needs to be updated to match with release requirements #4

tonyvugithub opened this issue Sep 22, 2020 · 0 comments · Fixed by #3

Comments

@tonyvugithub
Copy link
Contributor

tonyvugithub commented Sep 22, 2020 •
edited

It mentioned in the release requirements that

when processing a URL, your tool should attempt to do a network request of the given URL and check the resulting HTTP code. To begin with, an HTTP 200 result should be considered "good" and a 400 or 404 considered "bad." Any other result should be "unknown"
@1jz 1jz linked a pull request Sep 22, 2020 that will close this issue
update status code condition logic in main.go #3
Merged
@1jz 1jz closed this as completed in #3 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update status code condition logic in main.go tonyvugithub/WISA
1 participant
@tonyvugithub