Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge memory leaks #37

Closed
majkinetor opened this issue Dec 12, 2020 · 5 comments
Closed

Huge memory leaks #37

majkinetor opened this issue Dec 12, 2020 · 5 comments
Assignees
Labels
bug Something isn't working general-performance Performance related issue

Comments

@majkinetor
Copy link
Member

majkinetor commented Dec 12, 2020

Describe the bug

The application is leaking huge amounts of memory. While it is pretty snappy and fast during work, it slowly hogs the system down. Each time you start RDP session, it goes up. When nothing works (no session is active and PRM is in tray) it keeps all that memory.

The image bellow is after starting and closing 3 RDP connections total 15 times (which I do in my usual work in few hours) and letting it stay for the night (to see if the GC will kick in but it didn't). You can see it eats 2+ GB memory which is double the next most hungry app - Chrome browser.

image

Expected behavior

At least when no session is running and PRM is in tray, it should go next to the zero. This kind of tools should never use more then few hundred MBs.

@majkinetor majkinetor added the bug Something isn't working label Dec 12, 2020
@VShawn
Copy link
Member

VShawn commented Dec 13, 2020

bug confirm.
It seems like unrelease of AxMSTSCLib, but I tried Dispose() which gives no help at all.
More document about how the exit AxMSTSCLib correctly is needed.

image
image

@VShawn
Copy link
Member

VShawn commented Dec 13, 2020

looks like works

image

@majkinetor
Copy link
Member Author

Gr8. I'll test it again when you release this.

@VShawn VShawn closed this as completed in 651bbbb Dec 13, 2020
@VShawn
Copy link
Member

VShawn commented Dec 13, 2020

i found the huge memory leaks are fixed, still some little memory growth, I ignored them this time.

@majkinetor
Copy link
Member Author

I confirm this. It still eats memory quite a bit, without any connection just by bringing launcher it takes 150MB while it should probably take ~10... but that is all tolerable in current paradigm where electron apps can take much more doing no more then todo management.

@majkinetor majkinetor added the general-performance Performance related issue label Jan 13, 2021
VShawn added a commit that referenced this issue Dec 23, 2021
Signed-off-by: Shawn <singlex@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working general-performance Performance related issue
Projects
None yet
Development

No branches or pull requests

2 participants