Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0 BETA Build 20240220-0d35db creates wrong json #615

Closed
t-ru opened this issue Feb 20, 2024 · 3 comments
Closed

1.0.0 BETA Build 20240220-0d35db creates wrong json #615

t-ru opened this issue Feb 20, 2024 · 3 comments
Assignees
Labels
bug Something isn't working stale

Comments

@t-ru
Copy link

t-ru commented Feb 20, 2024

Describe the bug
Creating SSH Runner with UI resulting in wrong SSH.json

To Reproduce
SSH Runner "Plink on Windows Terminal" created.

exe path: wt.exe

Login with pw: -w 1 new-tab --title "%1RM_HOSTNAME%" --suppressApplicationTitle plink -ssh %1RM_HOSTNAME% -P %1RM_PORT% -%SSH_VERSION% -C -X -no-antispoof -l %1RM_USERNAME% -pw %1RM_PASSWORD%

Login witjh private key: -w 1 new-tab --title "%1RM_HOSTNAME%" --suppressApplicationTitle plink -ssh %1RM_HOSTNAME% -P %1RM_PORT% -%SSH_VERSION% -C -X -no-antispoof -l %1RM_USERNAME% -i %1RM_PRIVATE_KEY_PATH%

Result:

image

.... red is wrong

All runners affected.

@t-ru t-ru added the bug Something isn't working label Feb 20, 2024
@t-ru t-ru changed the title 1.0.0 BETA Build 20240220-0d35db creates wrong SSH.json 1.0.0 BETA Build 20240220-0d35db creates wrong json Feb 20, 2024
@VShawn
Copy link
Member

VShawn commented Feb 21, 2024

sorry Where is the wrong? I couldn't find the mistake. Value in the two ArgumentsForPrivateKey seem to be the same. Please help me identify where the wrong json is.

And I can start SSH with both password and private key by following the arguments you provided.

image

FYI: The two ArgumentsForPrivateKey is a technical debt left over from the upgrade of PRM to 1RM. Params will be removed after the official version is released.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Mar 23, 2024
Copy link

github-actions bot commented Apr 7, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants