Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] don't support dbus, or at least make support for it an opt-in compile-time option #5

Open
zetok opened this issue May 30, 2017 · 1 comment

Comments

@zetok
Copy link

zetok commented May 30, 2017

HAS MAJOR ISSUES RELATED TO SECURITY!!

Among things.

It's good to remember that when dbus craps out all the software that depends on it stops working.

I imagine that display manager ought to work regardless of whether dbus feels like working or not.

@zetok zetok changed the title [Feature request] don't support dbus, or at least make support for it to an opt-in compile-time option [Feature request] don't support dbus, or at least make support for it an opt-in compile-time option May 30, 2017
@1wilkens
Copy link
Owner

1wilkens commented Jun 7, 2017

Yeah I initially started adding dbus as I thought it would be required in "modern dms"(tm) but I no longer think that that is the case. The dbus crate is currently not used and could probably be removed.

The idea of an opt-in compile-time option sounds good, if I end up providing a dbus interface I will probably enable it through a cargo feature.

I will keep this open as long as dbus is still around in the codebase and not properly behind a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants