Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TaskListModal and SearchModal #211

Open
1 of 5 tasks
munen opened this issue Jan 5, 2020 · 0 comments
Open
1 of 5 tasks

Refactor TaskListModal and SearchModal #211

munen opened this issue Jan 5, 2020 · 0 comments
Labels
good first issue Good for newcomers refactor Refactor existing code

Comments

@munen
Copy link
Collaborator

munen commented Jan 5, 2020

1

  • Refactor TaskListModal and SearchModal into one component
  • New component has tabs (like Agenda)
  • The tab names are "Search" and "Task List"

2

  • Persist in which tab the user has been the last time

Routes:

  • #search-task-list
  • #search-general

3

  • Depending on context (search, task list or refile), save and show the last 10 filterStrings to localStorage
  • In org reducer, refactor setSearchFilterInformation to also get the scope (task list, search or refile) and save the searchFilterExpr in these scopes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Refactor existing code
Projects
None yet
Development

No branches or pull requests

1 participant