Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive web app isn't working in Firefox on Android #89

Closed
cwitte opened this issue Oct 30, 2019 · 8 comments
Closed

Progressive web app isn't working in Firefox on Android #89

cwitte opened this issue Oct 30, 2019 · 8 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cwitte
Copy link

cwitte commented Oct 30, 2019

When I go to in Firefox on Android, I expect there to be a button in the address bar "Add to homepage" as this is a PWA. The button doesn't appear. Let me know if I could provide more information to help debug this.

@munen
Copy link
Collaborator

munen commented Oct 30, 2019

Hi @cwitte

Thank you for the bug report. I don’t have an Android, so I cannot test this. It works fine in iOS. Having said that, I want it to work on Android, too, of course. That’s why I looked up the docs:

The latter shows the requirements for the button to appear on Android Firefox. Just reading them, I’d say organice qualifies for all.

I’d appreciate it if an Android user can point to the specific thing that’s missing. Any help is appreciated🙏🏻

@munen munen added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 30, 2019
@munen munen changed the title Pregressive web app isn't working in Firefox on Android Progressive web app isn't working in Firefox on Android Oct 30, 2019
@munen
Copy link
Collaborator

munen commented Nov 3, 2019

@AlexMihov Since you're an Android user, can you please verify that the PWA functionality of organice is indeed not working?

If you don't have the time, feel free to unassign yourself, of course(;

@AlexMihov
Copy link
Collaborator

@munen I can confirm, that with the newest Android Version 10 on a Pixel 3 with Firefox 68.2.0 I do not see the icon on the top next to the address bar.

On other pages, such as https://app.starbucks.com/ I do get the button, but there seems to be a bug with the default google launcher (or my phone behaves weirdly), since I do get the button and then a prompt, but when I accept, it does not add it to my home screen, where as it does work with third party launchers such as Nova Launcher;

The same is valid for Chrome on Android by the way;

@cwitte
Copy link
Author

cwitte commented Nov 15, 2019

From reading here: https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Add_to_home_screen
it appears to be missing a link to the manifest file in the header of the html file, something like:
<link rel="manifest" href="manifest.json">
I'm not 100% sure though and I don't know how to test it.

@munen
Copy link
Collaborator

munen commented Nov 15, 2019

@AlexMihov Thank you for double checking!

@cwitte Thank you for validating which of the requirements is missing. I just added a link as described by the documentation that you've sent.

image

Could you please retry, again? Please note that organice is using a ServiceWorker (https://github.com/200ok-ch/organice#pwa--offline-support), hence make sure to get the new version loaded into your browser(;

Thanks again for testing and debugging! 🙏

@vanous
Copy link

vanous commented Nov 15, 2019

I can confirm that the add to homescreen button is now visible and working on ff on android. Awesome job !

@cwitte
Copy link
Author

cwitte commented Nov 16, 2019

Great, it is now working for me too!

Thanks heaps.

@cwitte cwitte closed this as completed Nov 16, 2019
@munen
Copy link
Collaborator

munen commented Nov 16, 2019

Awesome, thanks everyone! (^-^)/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants