Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling of "deadline display" in responsive and mobile mode #923

Closed
munen opened this issue Jan 4, 2023 · 4 comments
Closed

Improve styling of "deadline display" in responsive and mobile mode #923

munen opened this issue Jan 4, 2023 · 4 comments
Labels

Comments

@munen
Copy link
Collaborator

munen commented Jan 4, 2023

#891 added a deadline display option on headlines. It works great and is a solid implementation. Only in responsive mode and on mobile devices, there's room for improvement.

This is what it looks like on an iPhone 13 pro in PWA mode:

3BDFBF3E-A2C4-44AD-9A96-1327722CAB57

Here it's in FF on Linux, using responsive mode to simulate a Galaxy 20:

image

@munen munen added good first issue Good for newcomers usability labels Jan 4, 2023
@munen
Copy link
Collaborator Author

munen commented Jan 4, 2023

@dmorlitz Pinging you here for reference, because I mentioned I'll open a new issue for the responsiveness improvement on the new deadline display. Not that you have to take action on it, anybody can take it up!

@dmorlitz
Copy link
Contributor

dmorlitz commented Jan 4, 2023

I have opened PR#925 (#925) which starts to fix some of these issues. This PR adds a non-breaking attribute to the overlaid date and increases the right margin on the overlay so it does not fall off the screen on the systems I tested it on. I want to see if I can more programmatically find the right margin - or change the span to a div - to avoid text falling off the screen in all cases

@dmorlitz
Copy link
Contributor

dmorlitz commented Jan 4, 2023

I do also want to quickly mention that the date in the "Doctor's appointment" in the Sample file is part of the Description and not an actual Deadline - which is why it renders differently in your screenshot above.

@munen
Copy link
Collaborator Author

munen commented Jan 9, 2023

Closed by #925

@munen munen closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants