Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes when colon in search term #26

Open
2016rshah opened this issue Apr 25, 2017 · 6 comments
Open

Crashes when colon in search term #26

2016rshah opened this issue Apr 25, 2017 · 6 comments

Comments

@2016rshah
Copy link
Owner

If you try to search for a book with a colon in the title it will crash.

Reproduce by trying to search for

Chaos Monkeys: Obscene Fortune and Random Failure in Silicon Valley

with and without the colon
@MasterOfTheTiger
Copy link

You can make the engine remove the colon.

@2016rshah
Copy link
Owner Author

Yeah, I'm treating this issue as a todo list item but I'm not sure if I'm gonna get around to fixing it any time soon.

If you want to send in a pull request I'd really appreciate it!

@MasterOfTheTiger
Copy link

Okay. I will have to learn how to do it though. I want to fix it.

@MasterOfTheTiger
Copy link

Where is the code for it?

@2016rshah
Copy link
Owner Author

It's a standard Ruby on Rails project, so that would be a good place to start learning!

The main code is in app/, you're probably looking for the code in app/controllers/ like the books controller and probably the search function.

@MasterOfTheTiger
Copy link

Okay! I’ve been wanting to learn Ruby on Rails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@2016rshah @MasterOfTheTiger