Fix typo related to intersections at endpoints #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly fixes a small typo in the translation of the JS algorithm to Rust. I already noticed that the Rust algorithm had a small difference compared to the JS on test case
issue103
. Basically it produced a spurious vertex next to another vertex. Not fully wrong, because it still followed the same shape, but not needed for the result:Tracking down the issue turned out that it is simply a
&&
that should have been||
(see JS side here). I have also added a new test case:Comparing the before and after coordinates at this case case, we can see that the spurious vertices around the correct vertices disappear:
I've also updated the readme a little bit.