Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coderwall form separate from preferences #801

Closed
indykid opened this issue Dec 13, 2014 · 8 comments
Closed

Coderwall form separate from preferences #801

indykid opened this issue Dec 13, 2014 · 8 comments

Comments

@indykid
Copy link
Member

indykid commented Dec 13, 2014

is this intentional? seems weird from user standpoint, may be combine so you dont have to submit 2 separate forms

@mth4saurabh
Copy link

Hi, I want to start contributing, this looks like a good place to start :)
These two forms go to different controllers(DashboardsController and CoderwallController),I think we can either move all logic to DashboardsController(does not seem like a good idea) or move the form somewhere else(creating icon like facebook,twitter).

@andrew
Copy link
Member

andrew commented Dec 15, 2014

@mth4saurabh Moving the form somewhere else sounds like a good idea, perhaps with a link from the coderwall badge area on the profile page?

@mth4saurabh
Copy link

@andrew Yeah I think that would work perfectly. I will start working on it immediately.

@indykid
Copy link
Member Author

indykid commented Dec 16, 2014

👍

@mth4saurabh
Copy link

@andrew I moved the form to profile page (added it below coderwall badges), while testing there is call to external service(coderwall) , I want to stub this request to external service; is it okay if I put it in spec_helper.rb ?

@andrew
Copy link
Member

andrew commented Dec 18, 2014

@mth4saurabh yeah that sounds good

@jasnow
Copy link
Contributor

jasnow commented Dec 4, 2015

This issue will probably be impacted by https://coderwall.com's parent company Assembly shutting down on December 6, 2015. Reference: https://news.ycombinator.com/item?id=10555710

@hugovk
Copy link
Contributor

hugovk commented Dec 8, 2016

This issue can be closed, as Coderwall was removed in PR #1702.

@andrew andrew closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants