Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Map] Hide found/own caches, cache types does not work #1478

Closed
anvanlaer opened this issue Oct 31, 2020 · 9 comments
Closed

[New Map] Hide found/own caches, cache types does not work #1478

anvanlaer opened this issue Oct 31, 2020 · 9 comments
Assignees
Labels
bug status: fixed bug fixing implemented
Milestone

Comments

@anvanlaer
Copy link

The new maps shows found and own caches. It worked fine untill a couple days ago. The last days the filters aren't activated in the search.

@capoaira
Copy link
Collaborator

Thank you for reporting the bug.

@2Abendsegler
GS made some internal changes to the map. https://forums.geocaching.com/GC/index.php?/topic/359138-release-notes-website-progressive-release-search-map-code-refactor-october-26-2020/ Maybe all features need to be checked for functionality.

@capoaira capoaira changed the title Map shows found and own caches again [New Map] Hide found/own caches, cache types does not work Oct 31, 2020
@capoaira capoaira added the bug label Oct 31, 2020
@2Abendsegler
Copy link
Owner

2Abendsegler commented Nov 7, 2020

I think the work is still in progress, so we have to be patient a little longer. We should observe the status of the work. When the work seems to be done, we can start to make the necessary adjustments in the GClh. I will set the status "on hold".

Yes, you are right, all features need to be checked for functionality. We do it here in this issue.

@2Abendsegler 2Abendsegler added this to the v0.10.10 milestone Nov 7, 2020
@2Abendsegler
Copy link
Owner

It appears that the changes to the site are complete. Maybe we can start with our adjustments.
Volunteers? 😊

@capoaira
Copy link
Collaborator

I'm maybe a voulenteer, but without much time....

@capoaira
Copy link
Collaborator

capoaira commented Nov 11, 2020

I found the following bugs


@capoaira
Copy link
Collaborator

capoaira commented Nov 12, 2020

Strange, sometimes some functions of the compact layout and also the "Show hint automatically" work, and sometimes they don't ...

Does anyone have an idea why?

Edit: Its because of the mutation obsever => #1489 (comment)

@capoaira
Copy link
Collaborator

@2Abendsegler Should an issue be opened (bit by bit) for each of the points?

@2Abendsegler
Copy link
Owner

Should an issue be opened (bit by bit) for each of the points?

Yes, makes sense.

@2Abendsegler
Copy link
Owner

@capoaira
Great job!


Merged
Changelog maintained

@2Abendsegler 2Abendsegler added status: fixed bug fixing implemented and removed status: wait for merge labels Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status: fixed bug fixing implemented
Projects
None yet
Development

No branches or pull requests

3 participants