Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading cache logs is failing #747

Closed
PontiacCZ opened this issue Aug 9, 2018 · 7 comments
Closed

loading cache logs is failing #747

PontiacCZ opened this issue Aug 9, 2018 · 7 comments
Assignees

Comments

@PontiacCZ
Copy link

Loading cache logs on cache pages or in the pop-up bubbles in the map is failing.

To Reproduce
Steps to reproduce the behavior:

  1. open the map and click either cache icon to get the pop-up window open, or
  2. open arbitrary cache page - for instance Olesna vyhled
  3. the wheel keeps spinning and no logs get ever loaded.

Expected behavior
Loading the logs and displaying their icons.

Desktop (please complete the following information):

  • OS: Windows 7 x64
  • Browser: Firefox
  • Version: 61.0.2
@2Abendsegler
Copy link
Owner

Thanks for the message!
We are already working on it.
#742 (comment)

@2Abendsegler 2Abendsegler added this to the v0.9.10 milestone Aug 9, 2018
@Ruko2010
Copy link
Collaborator

Ruko2010 commented Aug 9, 2018

Groundspeak fixed a typo in their own script, so our script (which relied on finding the text passage with the typo in it) stopped working. This fix will be rolled out in the next release.

@PontiacCZ
Copy link
Author

Great, you are fast, thank you. What was the typo by the way - I (or anyone interested) could fix it on my PC before you release a new version. :-)

@Ruko2010
Copy link
Collaborator

You can always see what we are changing by looking into the pull request:

image

Just click the Link 6a650b8

and you can see what changes are introduced in this pull request. In this case it is just one line:

image

@PontiacCZ
Copy link
Author

PontiacCZ commented Aug 10, 2018

Oh, I see now, thank you. I fixed those two typos here (initalLogs -> initialLogs) and saved. It helped in the map but not on the cache page, the VIP list still does not get populated.

Now, when I read my opening post I am sorry to realize that I was not quite clear - I actually meant the VIP logs area on a cache page (as the first ten logs icons were displaying even before fixing the typo).

@Ruko2010
Copy link
Collaborator

The thing with the VIP List is quite a bit complicated. You can follow the Ticket here: #745 (sorry, many things in German). In short, if you can live without the reload of cache logs in listing when scrolling down, you can search in the code for unsafeWindow.$(window).endlessScroll and comment out this function. You can still load all logs with the button "show all logs". This is only a temporary solution. We are working on a permanent one 😉

image

@PontiacCZ
Copy link
Author

Thank you so much - commenting out the entire function helped, the VIP list is working again. I am happy now :) and will wait until you roll out a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants