Bugfix missing sample files

[jacobvjk]

After erroneously deleting the sample_files directory in a past clean up, this PR adds it again.
This folder contains the files required to set up a new PACTA_analysis project.

What happens when a new project is initialised via the project_settings.yml, is that the copy_files() function https://github.com/2DegreesInvesting/PACTA_analysis/blob/fd928ba2e520d91806ba93004203070ed004d2f1/0_global_functions.R#L184
will add some basic folder structure and parameter files in the target directory. These files are taken from the sample_files folder, that I removed by accident.

It's easy to validate by setting the project name in the project_settings.yml to something random such as test_12345 and twodii_internal to TRUE and running the first script. This creates the corresponding directory on the 2dii dropbox.

@jdhoffa @maurolepore

[maurolepore]

After erroneously deleting the sample_files directory in a past clean up, this PR adds it again.

Given this fixes an accident, it seems high priority and it will clearly improve the health of the system (which would otherwise be broken). Thus I'm quick to say LGTM (looks good to me) -- provided you confirmed this does -- as I suspect -- this breaks nothing unespected. 🚀

It's easy to validate ...

I didn't validate -- I have no Dropbox desktop on my Linux system. But please do validate yourself.

--

Nit: I see multiple dummy.txt files. I wonder if there is a more elegant way to solve this. Maybe some function checks if these folders exist; and if they don't, it creates them on the fly, right before the directory is actually needed.

[maurolepore]

@jacobvjk,
I prefer to not merge this myself because I lack context or tests. Unfortunately, you seem to lack admin privileges to merge your own PR. So let me know if this is an emergency, and we can have someone to approve me giving you the required permission.

[jacobvjk]

@maurolepore I of course validated with the example I described above. But it's fine not to merge today. I will try to get @jdhoffa to do it tomorrow. It's urgent enough not to wait until Clare is back (in two weeks), but not urgent enough to warrant escalating it to emergency level today :)

[jdhoffa]

Lgtm

[jacobvjk]

@jdhoffa if you find time ti merge this today, that would be much appreciated. I don't have write access.

[maurolepore]

Do we need to give @jacobvjk admin permission?
It seems useful and safe -- given he understand git well.

cc' @jdhoffa, @2diiKlaus, @Clare2D

[2diiKlaus]

Sounds reasonable to me. Especially in times when @Clare2D is on vacation.

[jdhoffa]

agreed, I think @jacobvjk should have admin permissions

[maurolepore]

Thanks!

@jacobvjk, I increased your access permission. You now have rights to "write" to this repo. This is the minimum level I believe would give you the power you need. This can be changed at https://github.com/2DegreesInvesting/PACTA_analysis/settings/access.

[Clare2D]

This works for me too!

…

On Tue, Sep 8, 2020 at 5:02 PM Mauro Lepore ***@***.***> wrote: Thanks! @jacobvjk <https://github.com/jacobvjk>, I increased your access permission. You now have rights to "write" to this repo. This is the minimum level I believe would give you the power you need. This can be changed at https://github.com/2DegreesInvesting/PACTA_analysis/settings/access. [image: image] <https://user-images.githubusercontent.com/5856545/92493533-401bdb80-f1ba-11ea-9f6a-e4cc812b7dcb.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3BDIBFT7U7B76T34NQTWDSEZBQ5ANCNFSM4QR7LHVA> .