Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At product level, sector_profile*() should output profile_ranking #549

Closed
AnneSchoenauer opened this issue Sep 28, 2023 · 4 comments · Fixed by #613
Closed

At product level, sector_profile*() should output profile_ranking #549

AnneSchoenauer opened this issue Sep 28, 2023 · 4 comments · Fixed by #613
Assignees

Comments

@AnneSchoenauer
Copy link

AnneSchoenauer commented Sep 28, 2023

Relates to #566
Relates to #581

--

To add more transparency it would be great to understand also what the sector emission reduction target (SERT). So I envisioning to include this datapoint also in the output table. Could you please check where this data point lies and how to include it in the output table?

@AnneSchoenauer
Copy link
Author

Dear @maurolepore and @kalashsinghal - please note that I don't know if this issue is a tiltIndicator or a tiltIndicatorAfter package.

However, to update this ticket please find the following description.

Description:
We need to enhance the visibility of our emission reduction efforts by including the Sector Emission Reduction Target (SERT) in our reporting. The SERT data point is labeled as "reductions" within the "sector_profile_any_scenarios.csv.gz" file. The goal of this task is to update our existing R script(s) to read this data and include it in the final output table that is presented to stakeholders. Please note - it is fine if the SERT data point is called reductions - no need to rename it.

I think it works similiar to the column isic_digit and isic_categorisation so it shouldn't be a big problem I guess which you @mauro wrote this code for right?

@AnneSchoenauer AnneSchoenauer changed the title Adding the SERT data to the sector_profiles (also upstream) Adding the SERT data or 'reductions' variable to the sector_profiles (also upstream) Nov 7, 2023
@kalashsinghal
Copy link
Collaborator

kalashsinghal commented Nov 7, 2023

@AnneSchoenauer reductions column is ousted in tiltIndicator code and not tiltIndicatorAfter code. However, this column can be added in tiltIndicatorAfter code after calculating the risk categories through tiltIndicator. Please also confirm whether you need this column in product level table of Sector profile and Sector profile Upstream. right?

I think @maurolepore can work on this issue faster as he is merging the tiltIndicator and tiltIndicatorAfter code.

@AnneSchoenauer
Copy link
Author

@kalashsinghal okay great! Yes please for the product level table of sector profile and sector profile upstream.

@maurolepore please let me know if something is unclear and you need help.

@maurolepore
Copy link
Member

maurolepore commented Nov 14, 2023

This issue relates to #581, i.e. add profile_ranking` to the output.

--

scenarios$reducitons is identical to profile_ranking.

rename(profile_ranking = aka("co2reduce"))

tiltIndicator:::aka("co2reduce")
#> [1] "reductions"

@maurolepore maurolepore changed the title Adding the SERT data or 'reductions' variable to the sector_profiles (also upstream) Add profile_ranking to the output of sector_profile*() Nov 14, 2023
@maurolepore maurolepore changed the title Add profile_ranking to the output of sector_profile*() At product level, sector_profile*() should output profile_ranking Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants