Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Incomplete info and text squeeze #12

Closed
1 of 2 tasks
Wjplatformer opened this issue Aug 25, 2022 · 12 comments
Closed
1 of 2 tasks

[BUG]: Incomplete info and text squeeze #12

Wjplatformer opened this issue Aug 25, 2022 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@Wjplatformer
Copy link
Contributor

Wjplatformer commented Aug 25, 2022

Description of the bug

I had not reviewed my own projects pages in a while, and I found out that not all 17 of my projects are listed on the page. There is also a -1 repo on the repo counter. I tried deleting the fork and forking it again, but it didn't solve the issue. There is also a text squeeze when you search a project. This is a serious bug 💀

  • Incomplete info
  • Text Squeeze

Steps To Reproduce

  1. Go to https://wjplatformer.github.io/projects
  2. Count the number of repo's profiles (those square boxes) displayed versus the actual number.
  3. See the repo counter and go to https://github.com/Wjplatformer and see the GH repo counter and compare it to the projects counter
  4. Search some keywords
  5. See the text squeeze

Additional Information

profile display:
image
count display:
image
image
text squeeze:
image

@Wjplatformer Wjplatformer added the bug Something isn't working label Aug 25, 2022
@2KAbhishek
Copy link
Owner

By default forks are hidden in the list, see README to enable it

for the search issue some css tricks are needed, I don't have bandwidth right now, PRs welcome

@Wjplatformer
Copy link
Contributor Author

ok :)

@Wjplatformer
Copy link
Contributor Author

I've already made my fork visible but it still does not solve issue of my project's page incomplete issue. View it here. I will try to do the ccs tricks for the squeezing in the future.

@2KAbhishek
Copy link
Owner

just set hideForks = false and your forks will be visible

@Wjplatformer
Copy link
Contributor Author

oh. I GUESS the markdown is wrong 🤨. The markdown states that; to SHOW forks, set hideForks = true in script.js. Obviously, you should set hideForks = false. So, if you are like the people who die hard wants to follow instructions, then bad luck for me! In conclusion, hideForks = true in the markdown should be changed to hideForks = false. (Also, why is that variable set to true in the first place?)

@2KAbhishek
Copy link
Owner

Ahh, thanks for finding the bug in docs, I've fixed it, also the reason for hiding the forks by default was because I only wanted to show the source repos (since I already have too many of those!)

@Wjplatformer
Copy link
Contributor Author

ohh. that's alright then :)

@Wjplatformer
Copy link
Contributor Author

@2KAbhishek , however, BY default, My hideForks was set to false! And it still had that problem :|. I guess I have to retry changing it again (like now) and check in a few hours later or smth

@Wjplatformer
Copy link
Contributor Author

Oh! Incomplete info is fixed!

@Wjplatformer
Copy link
Contributor Author

@2KAbhishek , could you send me screenshot of your projects page when you search for a repo? Just checking as I have a different device and text squeeze is resolved. Thanks in advance 😄

@2KAbhishek
Copy link
Owner

The results are pretty similar to what you have shared, fixing there should provide a general fix

@Wjplatformer
Copy link
Contributor Author

Okie Dokie. I've just loaded the projects page on mobile, and that seems to be working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants