Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did automation of title and other stuff #4

Closed
wants to merge 1 commit into from
Closed

Did automation of title and other stuff #4

wants to merge 1 commit into from

Conversation

Wjplatformer
Copy link
Contributor

@Wjplatformer Wjplatformer commented Aug 4, 2022

What

What does this pull request accomplish?

  • Finished item

How

What code changes were made to accomplish it?

  • Created init.js
  • imported username variable from init.js to script.js
  • created a HTML tag in index.html which links to this repo

Why

  • I want to fix the issue # (issue)
  • I want to add a new feature
  • I want to improve the documentation
  • I want to fix the tests
  • I want to improve code organization (not putting the edits directly in script.js in this case

Screenshots (If applicable)

image

Notes

I added my own logo for no reason, I can delete it if you want :)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@2KAbhishek
Copy link
Owner

Thanks for the PR, but I believe it's a better idea to directly update this data in the main script.

This will increase rendering times and break an already simple logic further.

@2KAbhishek 2KAbhishek closed this Aug 4, 2022
@Wjplatformer
Copy link
Contributor Author

Alright then. I did (pretty slow) render time anyways. Thanks!

@Wjplatformer Wjplatformer deleted the Wjplatformer-init-file branch August 5, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants