Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5.4] Animation never complete on widget test #129

Open
nanzhang1 opened this issue Jul 16, 2019 · 2 comments
Open

[1.5.4] Animation never complete on widget test #129

nanzhang1 opened this issue Jul 16, 2019 · 2 comments

Comments

@nanzhang1
Copy link

After upgrade to flare 1.5.4 (required by flutter upgrade to 1.7), we started to have our widget test fail.
After debugging , we found that in flare_cache_asset.dart, asset were not loaded before the test fail.
This is not an issue in 1.5.1

@luigi-rosso
Copy link
Contributor

Can you post a code example of the widget and test? The loading is now async so you may need to pump multiple times.

@nanzhang1
Copy link
Author

Hi @luigi-rosso :
here is a code and test example:
below widget build FlareActor and the callback tell us the animation has complete and we'll forward in our flow, the call back is hit when I run the app but is not hit when I run the test.

Widget _getFlareAnimation(BuildContext context, String animationName) {
return Center(
child: Container(
width: 206,
height: 120,
child: FlareActor(
'packages/syi_ui/flare/vin_details_animations.flr',
alignment: Alignment.center,
fit: BoxFit.contain,
animation: animationName,
callback: (name) {
Provider.of(context).flareAnimationComplete();
},
),
),
);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants