Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design board exposed (probably) during animation transitions #136

Closed
yjoo9317 opened this issue Aug 6, 2019 · 11 comments
Closed

Design board exposed (probably) during animation transitions #136

yjoo9317 opened this issue Aug 6, 2019 · 11 comments
Assignees

Comments

@yjoo9317
Copy link

yjoo9317 commented Aug 6, 2019

Dear @luigi-rosso

Recently I noticed that flare actor is often exposing design board right before playing animation.
The app dynamically changes animations between states and during the state transition,
we started seeing that happens.
Do you know any possible reason for me to see the design board?

Note:
I changed the version to 1.5.4 from 1.5.0 a week ago.
The reason I am putting this is that it seems like we didn't have this issue before.

Thanks.

@luigi-rosso
Copy link
Contributor

Hey @yjoo9317, can you post a screenshot or video showing the issue? I'm not sure I'm following what you're seeing. Is it that you see the background color of the artboard?

@luigi-rosso luigi-rosso self-assigned this Aug 6, 2019
@yjoo9317
Copy link
Author

yjoo9317 commented Aug 6, 2019

I cannot confirm exactly what it is.
But, at least I can tell that it showed the initial design assets of all animations in the flare file.
Still, not enough...hmm,
If the flare animation has 2 animation sequences, then it (may) shows the overlapped initial frame of both animations.

@yjoo9317
Copy link
Author

yjoo9317 commented Aug 6, 2019

@luigi-rosso
I forgot to mention something.
I wasn't able to use sizeFromArtboard property for my project.
Using that property, when the widget dynamically changes animation, it often showed that overlapped sequence.

Here is what I am going to do.
I will run same test with version 1.5.0 to see if it happens there.

  1. If it doesn't, then there is regression in the flutter.
  2. If it does as well, then.. I don't know.. any idea?
    or Do I have to do something at didUpdateWidget?

Let me know.
Thanks.

@yjoo9317
Copy link
Author

yjoo9317 commented Aug 7, 2019

HI @luigi-rosso
Our flare file contains two animations, thinking and progress bar.

Here is the thinking animation screen shot.
Screen Shot 2019-08-07 at 9 21 05 AM

Here is the thinking animation shot with overlapped progress bar.
It seems to happen (possibly) when re-constructing the widget by update.
Screen Shot 2019-08-07 at 9 21 16 AM

Right now, I check cachedActor and get the artboard, and only then I call setState.

If I start using sizeFromArtboard property then it happens more in a more dynamic situation. Also with that, from widget side, I have less control over (since now everything is under FlareActor) and hard time to know what is going on there.

@yjoo9317
Copy link
Author

yjoo9317 commented Aug 8, 2019

Hi @luigi-rosso,
I know you must be so busy with everything.
Do you have any thought on this issue?

Thanks really.

@luigi-rosso
Copy link
Contributor

Sorry, I haven't had time to dive into this in detail yet! I hope to find some time soon!

In the meantime, how are you mixing the two animations? Could it be that keyframes from one are not being reset by the other? It'd be really helpful if you could share code and/or a video of the problem to help me better understand what your intention is and where it's failing. It'd also be really helpful if you could share the Flare file with me. If it's private, you can download a backup and email it to me at luigi@2dimensions.com.

Does it look any different in release/debug builds?

@yjoo9317
Copy link
Author

yjoo9317 commented Aug 8, 2019

Hi @luigi-rosso

I didn't mix it.
Flare showed the everything some how, that's why I thought it was a design board in the first place.
Not 100% sure.. Looks like if I run animation with controller.isActive.value = false then it just shows everything like that.
As such, during the transitions in my app, there is moment when the controller can be deactivated.

Does it ring any bell?

@luigi-rosso
Copy link
Contributor

It's possible that a controller gets re-initialized if the widget gets detached and then re-attached.

This sounds really strange, almost like an animation from one file is being applied to a different file corrupting some of the shapes. If you get the chance, share both the code and the original Flare file so I can look in-depth at exactly what's going on...

@yjoo9317
Copy link
Author

yjoo9317 commented Aug 8, 2019

Hmm, it is one .flr file containing 2 different animations.

Since there could be copy right issue..
I am in the middle of something.
Please give me some time to create a simple app that I can repro this.

@yjoo9317
Copy link
Author

yjoo9317 commented Aug 9, 2019

Hi, @luigi-rosso

I sent a video clip.
Would you please verify if you received that? Thanks.
If you look at the video, you will see what I am talking about.
Whenever hero transition starts, it shows that symptom.

I haven't created the sample app yet, but the video was taken from my debug page for flare animations.

@yjoo9317
Copy link
Author

yjoo9317 commented Aug 9, 2019

@luigi-rosso
Seems like I found the issue.
I didn't set animation name while creating actor since our custom flare controller controls animations and the animation is being loaded there.
But I notice if I don't set the animation name in creating flareactor, I have moment showing briefly every underlying animation on the same frame until it knows what to play.
Not sure, it should be addressed publicly. But that's what I had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants