Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The actor is broken #22

Closed
HaoliangHsiao opened this issue Dec 21, 2018 · 11 comments
Closed

The actor is broken #22

HaoliangHsiao opened this issue Dec 21, 2018 · 11 comments

Comments

@HaoliangHsiao
Copy link

The Penguin will be broken when I stop "walk" animation by isPaused parameter.
Please help this. Thank you.

2018-12-21 10 51 29

@luigi-rosso
Copy link
Contributor

Are you running the example/penguin_dance app or have you made any modifications to it? Could you share your source, if so?

I don't see this on my side, but I'm curious if you're doing something that's causing the actor to not advance after an update.

@kmckinley
Copy link

I'm having the same problem in my project. I have a simple animation and after I run it one and then update isPaused to true it stops animating, but afterward, when I attempt o update isPaused to false it doesn't start animating again.

@kmckinley
Copy link

Update: I went and looked at the penguin example to see if I had the same issue like @HaoliangHsiao mentioned, but I did not. I checked the version for flare_flutter and it was using 1.0.5, but my project was on 1.0.4. I updated my project to 1.0.5 and the issue went away.

@luigi-rosso
Copy link
Contributor

I think this new issue @HaoliangHsiao is facing could be related to flutter/flutter#25426. Try running flutter upgrade to see if it was related to that issue. Let me know, I can't seem to repro this with any of the examples.

@HaoliangHsiao
Copy link
Author

I used your demo code 'Rockin' Penguin' on Pixel 3 Max.

This is my Flutter doctor :
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.1.5-pre.16, on Mac OS X 10.13.6 17G65, locale
zh-Hant-TW)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.1)
[✓] Connected device (1 available)

device-2018-12-22-103444
device-2018-12-22-103424

@luigi-rosso
Copy link
Contributor

Thanks @HaoliangHsiao, could you try it in release mode and see if it makes a difference?

@HaoliangHsiao
Copy link
Author

I try to uesd v1.1.4, The issue will happen a few times.
[✓] Flutter (Channel master, v1.1.4, on Mac OS X 10.13.6 17G65, locale
zh-Hant-TW)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.1)
[✓] Connected device (1 available)
device-2018-12-22-105528

@luigi-rosso
Copy link
Contributor

I'm curious if it works in release mode as I have a similar issue with a Pixel 2 that corrupts the graphics in debug mode, but works fine in release.

flutter run --release

I might need to go pick up a Pixel 3 :-)

@HaoliangHsiao
Copy link
Author

@luigi-rosso This issue does not happen on release build. It's work. Thank you.

@luigi-rosso
Copy link
Contributor

We should open this issue on the Flutter repository as clearly there's something quite reproducible here that's affecting the Pixel devices. I'm on it :)

@luigi-rosso
Copy link
Contributor

I was able to reproduce this on my Pixel 2, but it's somewhat random, as if you have to stop it on the right frame that somehow causes the problem. It's much clearer in the https://github.com/2d-inc/Flare-Flutter/tree/master/example/simple where it can be seen while the animation is playing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants