Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character modal should have a max height #76

Closed
neurowave opened this issue Apr 26, 2019 · 6 comments
Closed

Character modal should have a max height #76

neurowave opened this issue Apr 26, 2019 · 6 comments

Comments

@neurowave
Copy link

This modal should probably not scale more than its contents' height. Separately, and not as important, we might want to give the character area a darker background… the glows don't look great on the white background.

Simulator Screen Shot - iPad Pro (12 9-inch) (2nd generation) - 2019-04-26 at 16 19 46

@neurowave
Copy link
Author

This will also improve how this looks on the iPhone XS max (and XR)…

Simulator Screen Shot - iPhone Xs Max - 2019-04-26 at 16 13 18

@efortuna
Copy link
Collaborator

It also feels too narrow. I'd like it to be a little wider, or at least some more padding arouind the edges

@neurowave
Copy link
Author

@efortuna I think that's because it's the exaggerated height that's making it look that way. I went ahead and updated the designs with extra padding and bigger font size with better line-height for the body text. Adding this to Zeplin!

Character Modal

@neurowave
Copy link
Author

I updated these with a dark background since the glows behind most of the characters aren't looking so great on white backgrounds. Here's how it looks…

Character Modal dark
Character Modal Tablet dark

@luigi-rosso
Copy link
Contributor

Looks like this if we set the max height to 75% of the max width:
image

@neurowave
Copy link
Author

That's definitely better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants