Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think 'only deletable mode' is needed #82

Closed
su-mong opened this issue Aug 4, 2019 · 2 comments
Closed

I think 'only deletable mode' is needed #82

su-mong opened this issue Aug 4, 2019 · 2 comments

Comments

@su-mong
Copy link

su-mong commented Aug 4, 2019

Thank you for providing good library. I think it is very useful and easy, so I'm satisfied with using your library.

I think this library can be more useful if there is 'only deletable mode'. When I making my application, I need deletable tags, but I don't want 'add a new tag' function. That means, I don't want the function that users can write their own tags. So, I override your library and making my own tag library by deactivating 'appendInputTag()' function.

I think some of this library users want this function that I made. Can you add the 'only deletable mode'? It can be useful for us.

@andrewindayang
Copy link

hi @Candykick you can take the library class.

so gradle implement the library :
implementation 'me.gujun.android.taggroup:library:1.4@aar'

then take this file : https://github.com/2dxgujun/AndroidTagGroup/blob/master/library/src/main/java/me/gujun/android/taggroup/TagGroup.java

make new class into your project then extend the R.attr using your own Resources and it will automatically solved.

then
protected void appendInputTag() {
// appendInputTag(null); //COMMENT OUT THIS LINE
}

THIS WILL SOLVE IT. 👯 HOPE IT HELPS!!

@su-mong
Copy link
Author

su-mong commented Aug 7, 2020

hi @Candykick you can take the library class.

so gradle implement the library :
implementation 'me.gujun.android.taggroup:library:1.4@aar'

then take this file : https://github.com/2dxgujun/AndroidTagGroup/blob/master/library/src/main/java/me/gujun/android/taggroup/TagGroup.java

make new class into your project then extend the R.attr using your own Resources and it will automatically solved.

then
protected void appendInputTag() {
// appendInputTag(null); //COMMENT OUT THIS LINE
}

THIS WILL SOLVE IT. 👯 HOPE IT HELPS!!

Oh Thank you! I did it by overriding some classes in this library, but your answer is much greater than mine.

@su-mong su-mong closed this as completed Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants