Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on Bower #382

Open
FluorescentHallucinogen opened this issue Oct 10, 2016 · 8 comments
Open

Publish on Bower #382

FluorescentHallucinogen opened this issue Oct 10, 2016 · 8 comments

Comments

@FluorescentHallucinogen

Please create bower.json file and publish this package in Bower registry .

@Trufi
Copy link
Contributor

Trufi commented Oct 14, 2016

Can you explain how we add the package to bower without built files in the repository?

@FluorescentHallucinogen
Copy link
Author

Why not add built files into the repo? It's not an anti-pattern anymore.

@FluorescentHallucinogen
Copy link
Author

2gis-maps-react package now available on Bower. But looks like it requires 2gis-maps package. But 2gis-maps is not available on Bower. That's why I've opened this issue.

I'm not sure 2gis-maps-react really requires 2gis-maps, because package.json of 2gis-maps-react doesn't contain "2gis-maps" in "dependencies", but README.md of 2gis-maps-react suggests use npm install 2gis-maps-react 2gis-maps command for installation instead of just npm install 2gis-maps-react. See 2gis/2gis-maps-react#7.

@FluorescentHallucinogen
Copy link
Author

BTW, since you use Git tags, if you'll add built files into the repo, you can serve them directly from GitHub with proper Content-Type header using RawGit (https://rawgit.com), a free service based on MaxCDN's (https://maxcdn.com) super fast global CDN. 😉

And please don't forget to update GitHub releases.

@Trufi
Copy link
Contributor

Trufi commented Oct 31, 2016

We will not add build files because it creates many merge conflicts and makes code review more difficult.

I think we can look into how https://github.com/Leaflet/Leaflet doing this without built files in the repo.

@FluorescentHallucinogen
Copy link
Author

Any progress?

@Trufi
Copy link
Contributor

Trufi commented Nov 18, 2016

Sorry I am a little bit busy right now, but you can create your own pull request

@FluorescentHallucinogen
Copy link
Author

Should all packages from "dependencies" and "devDependencies" be published on Bower?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants