-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Community Showcase Handbook as a JupyterBook #22
Comments
So, the workflow I've always used previously is this:
I think the GitHub Actions option is a dressed up version of how they used to automate jekyll deployments which is old and janky. |
Ok! "Classic" GitHub Pages it is! @sgibson91 are you ok to fix/replace my first attempts to set up a JupyterBook within this repository as your first deliverable under sprint 3? |
@jmunroe Yep! |
Actually one follow-up question. Any particular reason for GitHub Pages over, say, readthedocs? GitHub Pages doesn't support deploy previews, so you can't visually check changes to the site before deploying them. Of course you can always build the docs in a PR and make sure they pass, but that's not the same as them being visually coherent. |
The visual preview I am expecting is to build the JupyterBook within a JupyterLab instance, verify it looks the way it is intended, then check in the changes and have reasonable confidence that the GitHub pages deployment will look the same. With RTD it's not clear to me how to render a RTD site without having first to make a commit and have RTD hooks build the site. My intent is to have an authoring environment for JupyterBook that does not depend on tooling outside of what we can put inside of an environment image container. |
That's totally fair. I was more curious than worried we were making a technical blunder. |
Expect a few debug PRs now as I double check the workflow actually runs correctly 😄 |
Ok, the site is now live at https://2i2c.org/community-showcase/ |
I am seeing different GitHub actions and its not clear to me which action is doing what. There is the Build and Deploy Handbook workflow (as described in But then there is also this pages-build-deployment workflow that although I see the action has been running, it doesn't appear defined in Are one of these way the 'old way' and the other the 'new way'? Or are they both used? Also, I was expecting the JupyterBook to only be available through https://2i2c-org.github.io/community-showcase (which does work) but it seems "somehow" this is redirects to https://2i2c.org/community-showcase . There is nothing in the GH Pages configuration about setting 'custom domain' so I am not clear on why this is working. |
So all
I was also expecting this and was also a little surprised, but I think I understand now. The https://github.com/2i2c-org/2i2c-org.github.io repo builds our https://2i2c.org site using GitHub Pages, and in it's settings you can see that the custom domain field has been filled such that it is served at
Hope this helps! |
Thank you! That makes it much more clear that And I appreciate understanding what is going on with the domain redirection. That makes a lot of sense that it is the https://github.com/2i2c-org/2i2c-org.github.io repo where the custom domain is being specified. |
This completes what was envisioned for this issue! Closing. |
Explorations from #17 suggest the following path:
handbook
that will contain the content of a JupyterBook for a 'Community Showcase Handbook'handbook
with a skeleton of a JupyterBook.github/workflows/deploy_handbook.yml
as needed to that the JupyterBook is built and pushed to GH Pages and so that this action is trigger if and only a change to thehandbook/
subdirectory is madeThe text was updated successfully, but these errors were encountered: