Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write technical content for guiding communities on how to build custom images for their hubs. #210

Closed
Tracked by #214
jnywong opened this issue Mar 7, 2024 · 7 comments · Fixed by #213
Closed
Tracked by #214
Assignees

Comments

@jnywong
Copy link
Member

jnywong commented Mar 7, 2024

No description provided.

@jnywong jnywong self-assigned this Mar 7, 2024
@yuvipanda
Copy link
Member

yuvipanda commented Mar 7, 2024

I gave a talk about this exact topic at JupyterCon last year. https://www.youtube.com/watch?v=qgLPpULvBbQ

Slides at https://docs.google.com/presentation/d/16V6ylmirxxBTlVq-tZ9dsFYCf1Abbl83Rv350Rc-DL4/edit#slide=id.p

I would consider the talk / slides as current best practice, which unfortunately is not reflected in the documentation we already have.

@jnywong
Copy link
Member Author

jnywong commented Mar 8, 2024

Thank you @yuvipanda for sharing your talk, I think many communities will benefit from this being documented in our Service Guide docs.

@jnywong
Copy link
Member Author

jnywong commented Mar 14, 2024

As a starting point I am going to document "Use upstream maintained image + packages" first, since this seems to be the most pertinent use case identified.

@jnywong
Copy link
Member Author

jnywong commented Mar 14, 2024

Coming up against a GH action failure when replicating the example in https://github.com/yuvipanda/example-inherit-from-community-image. Build logs indicate a problem with accessing repo contents:

ls: cannot access 'image-tests/*.ipynb': No such file or directory
ERROR: file or directory not found: image-tests/

@yuvipanda
Copy link
Member

@jnywong ah, this is great. I would say that the immediate way for you to unblock yourself is to remove the image-tests directory in the repo - I think it's a nice to have but not fundamentally essential. The image-tests feature was added in jupyterhub/repo2docker-action#83, and probably there's some bug here in how that's working.

So my suggested action items here are:

In general this is also a good workflow for unblocking ourselves i think:

  1. Do the minimum necessary to immediately unblock ourselves
  2. But always report the issue upstream where it needs to be. Figuring out where this needs to be can be difficult, and is something I am happy to help with!
  3. Once it's fixed upstream somehow, we can incorporate it back into our work here.

I think this allows us to keep moving while also overall improving the quality of the Jupyter ecosystem!

@jnywong
Copy link
Member Author

jnywong commented Mar 15, 2024

Thanks for this @yuvipanda ! Wise words that I will be taking forward with me in general 👍

@yuvipanda
Copy link
Member

@jnywong glad to be of help!

@jnywong jnywong changed the title Plan technical content for guiding communities on how to build custom images for their hubs. Write technical content for guiding communities on how to build custom images for their hubs. Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants