Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy kubespawner from specific commit into our infrastructure #1825

Closed
Tracked by #1253
damianavila opened this issue Oct 27, 2022 · 4 comments · Fixed by #1849 or #1856
Closed
Tracked by #1253

Deploy kubespawner from specific commit into our infrastructure #1825

damianavila opened this issue Oct 27, 2022 · 4 comments · Fixed by #1849 or #1856
Assignees

Comments

@damianavila
Copy link
Contributor

damianavila commented Oct 27, 2022

Ref: #1253

@yuvipanda suggested deploying from a specific commit because of breaking changes in kubespwner.

@GeorgianaElena
Copy link
Member

GeorgianaElena commented Nov 1, 2022

Before going down this path, just want to first double-check with @consideRatio what's his feeling around a new kubespawner release and whether or not I can be of help.

@consideRatio, do you think now is a good time to push for a new kubespawner release? I believe I can help out with that.
If not, maybe I can help with pushing forward the blocking pieces of a release?

Nonetheless, I will be deploying an unreleased version for 2i2c until we figure it out.

@consideRatio
Copy link
Member

consideRatio commented Nov 1, 2022

@consideRatio, do you think now is a good time to push for a new kubespawner release? I believe I can help out with that.
If not, maybe I can help with pushing forward the blocking pieces of a release?

@GeorgianaElena do go for it! I think a key point about making a release is to figure out if it is a good time or not. I'd say its pretty much always a good time though - I'm thinking "why not make a release" and don't have a clear answer.

I think if you get started by creating a changelog, you will automatically end up learning about the changes made and can reflect if something is seen as problematic.

Btw here are some added details to what I think of when making a release, not part of RELEASE.md for specific projects. Certainly worth adding to and updating etc if you think of something! jupyterhub/team-compass#563


PS: Atm I'm a bit out of touch with what has changed in KubeSpawner, but I recall quite a bit of changes relate to KubeIngressProxy which is unrelated to KubeSpawner itself but part of that package for now.

@GeorgianaElena
Copy link
Member

Thanks for the guidance @consideRatio!

After speaking with @damianavila, I believe the plan now is:

  • get 2i2c on jupyterhub/kubespawner@fa19acd version so we don't block the new profile list options
  • get started on building the changelog for a new kubespawner release and see where or if it blocks in the review process. We can then see which are the sensitive or blocking points if any.

@GeorgianaElena
Copy link
Member

I'm reopening this because the new hub image deploy has broke the staging hubs that used profile options because of bug jupyterhub/kubespawner#662 I've introduced :(

I hadn't time to check the entire changelog of kubespawner. @yuvipanda, do you know if there are any breaking changes for 2i2c hubs specifically there if I were to use latest main commit?

Otherwise, I was thinking to pin to a commit on your fork https://github.com/yuvipanda/kubespawner/commits/async until I figure out the kubespawner changelog and possibly release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants