Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should @types/lodash be a non-dev dependency? #184

Closed
jaydiablo opened this issue Jan 16, 2020 · 1 comment
Closed

Should @types/lodash be a non-dev dependency? #184

jaydiablo opened this issue Jan 16, 2020 · 1 comment

Comments

@jaydiablo
Copy link

I noticed on Snyk (https://snyk.io) that this project pulls in @types/lodash as a non-dev dependency.

https://github.com/2muchcoffeecom/ngx-restangular/blob/master/projects/ngx-restangular/package.json#L49

This should be moved to the devDependencies section right?
@rshchpkn
Copy link
Collaborator

Hi @jaydiablo, Thanks for your question. It shouldn't be moved to devDependecies as in this way it won't be installed when ngx-restangular is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaydiablo @rshchpkn