Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add MARY protocol version to handshake protocol #58

Closed
AndrewWestberg opened this issue Mar 19, 2021 · 3 comments · Fixed by #61
Closed

[FEAT] Add MARY protocol version to handshake protocol #58

AndrewWestberg opened this issue Mar 19, 2021 · 3 comments · Fixed by #61

Comments

@AndrewWestberg
Copy link
Contributor

If we pass 0x06 as a MsgProposeVersion and the remote node is running 1.26.0 or higher, we will get back a MsgAcceptVersion with 0x06 in the payload.

The difference between 0x05 and 0x06 is that the TxSubmissionProtocol has its starting agency flipped around the same as all the other protocols. In 0x05, the remote server started with agency so we had to spin up TxSubmissionProtocol right away to listen for messages from the server. In 0x06, when doing regular syncing with the node, we can not connect TxSubmissionProtocol at all since the server will be waiting on us forever to send something.

When doing a sync, we should update to support 0x06 and just omit adding TxSubmissionProtocol if the server responds with 0x06.

@AndrewWestberg AndrewWestberg added the enhancement New feature or request label Mar 19, 2021
@mark-stopka
Copy link
Member

@pavlix can you scope the required work in terms of effort in MH?

@mark-stopka mark-stopka changed the title Add MARY protocol version to handshake protocol [FEAT] Add MARY protocol version to handshake protocol Mar 22, 2021
@mark-stopka mark-stopka added this to To do in Project Catalyst Fund 3 deliverables via automation Mar 22, 2021
@mark-stopka mark-stopka added this to the Project Catalyst Fund 3 - Deliverables milestone Mar 22, 2021
@mark-stopka
Copy link
Member

@pavlix ping?

@mark-stopka
Copy link
Member

@pavlix ping?

Can you quote me the required statements of works?

@mark-stopka mark-stopka linked a pull request Apr 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream change
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants