Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extendHex not working properly #223

Closed
flxwu opened this issue Dec 17, 2017 · 1 comment · Fixed by #224
Closed

extendHex not working properly #223

flxwu opened this issue Dec 17, 2017 · 1 comment · Fixed by #224

Comments

@flxwu
Copy link
Contributor

flxwu commented Dec 17, 2017

This is the snippet I created once, but someone has rewritten it wrongly.
extendHex(03f) should return #0033ff, but currently returns #03f03f .

The problem was here:

shortHex.slice(shortHex.startsWith('#') ? 1 : 0).split().map(x => x+x).join()

but should be

shortHex.slice(shortHex.startsWith('#') ? 1 : 0).split('').map(x => x+x).join('')

Is fixed in my PR #224

@lock
Copy link

lock bot commented Dec 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant