Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Ownership #26

Closed
304NotModified opened this issue Apr 27, 2017 · 17 comments
Closed

Ownership #26

304NotModified opened this issue Apr 27, 2017 · 17 comments
Milestone

Comments

@304NotModified
Copy link
Owner

304NotModified commented Apr 27, 2017

Hi @SimonCropp!

I'm thinking to volunteer for the ownership (if someone else is also interested, please reply - I like working in teams!)

Could we arrange a transfer of your knowledge (how to build, how to publish, (build) scripts, which projects to edit, caveats etc?) - on chat or mail?

@SimonCropp
Copy link
Collaborator

SimonCropp commented Apr 28, 2017

All that is fine. Although i generally recommend peopke use gitversion these days https://github.com/GitTools/GitVersion

@SimonCropp
Copy link
Collaborator

i cant transfer while you have a fork

@304NotModified
Copy link
Owner Author

Hi @SimonCropp

Thanks!

I'm a bit more busy compared to a few months ago. I still have interest in maintaining it, but I think it's a good step to first check the code in-depth and then transfer the knowledge.

I will try to do that this week/weekend.

@304NotModified
Copy link
Owner Author

@SimonCropp we are still using the lib, with pleasure.

I would like to maintain this repo, but first I'm I like to know:

  • what is the code inside Fody/PeImage and /Fody/VersionResources?
  • this code is more complicated compared to https://github.com/krk/Stamp. (SVN Stamp). Any idea why?

@SimonCropp
Copy link
Collaborator

Fody/PeImage and /Fody/VersionResources

you are best of asking @qmfrederik #19

i have not looked at SVN stamp. so cant speak to it

@304NotModified
Copy link
Owner Author

@SimonCropp it has been a long time, and I like to fix #27. Also I like to merge some PRs

So I think it would be nice if I could transfer it, I have a fork, but I prefer to be owner of the current repo (so PRs stay intact).

@qmfrederik
Copy link
Contributor

re: what is the code inside Fody/PeImage and /Fody/VersionResources?

It is the managed equivalent of verpatch.exe. It patches the executable to add version information. It's what you see when your right-click a file in Windows Explorer and open the file properties.

Replacing verpatch.exe with managed code allowed us to use Fody/Stamp on macOS and Linux using Mono.

Lots has changed since we opened that PR two years and a half ago; we now use .NET Core together with NerdBank.GitVersion, so we don't rely on Fody/Stamp any more.

@304NotModified
Copy link
Owner Author

Thanks @qmfrederik :)

@SimonCropp
Copy link
Collaborator

@304NotModified i dont think i can transfer ownership to u while u have an active fork

@304NotModified
Copy link
Owner Author

I removed my fork

@SimonCropp
Copy link
Collaborator

what is your nuget name?

@304NotModified
Copy link
Owner Author

The same as Github: https://www.nuget.org/profiles/304NotModified

@304NotModified
Copy link
Owner Author

@SimonCropp I see that you did the transfer, but the request was in my spambox.

Could you please resend it? And please let me know, as the request expires in 24h

thanks!

@SimonCropp
Copy link
Collaborator

done

@304NotModified
Copy link
Owner Author

304NotModified commented Aug 30, 2018

thanks! It's transferring now!

@304NotModified
Copy link
Owner Author

resolved :) Thanks!

@304NotModified
Copy link
Owner Author

304NotModified commented Aug 30, 2018

what is your nuget name?

@SimonCropp could you please add me to https://www.nuget.org/packages/Stamp.Fody/?

-> #29

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants