Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a suitable app icon and name #2

Closed
danger-ahead opened this issue Nov 13, 2021 · 6 comments
Closed

Adding a suitable app icon and name #2

danger-ahead opened this issue Nov 13, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@danger-ahead
Copy link
Contributor

The app still has the default Flutter launcher icon.

The name has still not been changed from notes_app.

Working on these two could increase the appeal of the app to the users.

Loved the UI and working of the app. Would love to collaborate.
If you want me to work on this issue, feel free to assign.
Also I'd need the new icon file and the updated app name as per your wish.

@31Carlton7
Copy link
Owner

If you would like, you can email me a custom launcher icon in .png format and I'll update the app to include it, because I personally like to do it a certain way.

You can submit a pull request to update the app name to "Notes" as I think it's the most fitting. (I also don't have a very creative name in mind)

Thank you very much for the feedback! Please see the README.md to get an idea of the app's future implementations going forward, and let me know which part you would like to contribute to.

@danger-ahead
Copy link
Contributor Author

danger-ahead commented Nov 14, 2021

If you would like, you can email me a custom launcher icon in .png format and I'll update the app to include it, because I personally like to do it a certain way.

You can submit a pull request to update the app name to "Notes" as I think it's the most fitting. (I also don't have a very creative name in mind)

Thank you very much for the feedback! Please see the README.md to get an idea of the app's future implementations going forward, and let me know which part you would like to contribute to.

Thanks.
I would like to work on the authentication feature. And for this, I'd be using the local_auth package.

Also I'd be changing the name and issuing a PR shortly.

@31Carlton7
Copy link
Owner

I would like to work on the authentication feature

This will be good for the lock notes implementation. I previously had one but removed it because I felt like it was too glitchy.

Before implementing this, take a very very VERY good look at the code structure, and if you want me to, I can break it down to demonstrate how it works. It must stay consistent.

Here is a list of steps to complete the process and let me know if something doesn't work.

  1. Add a new non nullable bool called locked to the note.dart model. This is located in lib/src/models/note.dart. Add that and update the rest of the parameters and methods to include it.
  2. You'll probably notice that there are errors, because you didn't add the locked parameter to certain methods. I think there should be an error in the _completeNoteFunction() in the note_creation_view.dart, so add the locked parameter and set it to false. Do this in any other occurrences you see.
  3. Next, Update the note_card.dart file to change the title and content if the note is locked. You can add another if statement inside of the _contentText() method and _titleText() methods there. Then update _body() to hide the tags if the note is locked. The file is located in lib/src/ui/components/note_card.dart
  4. Then create a new note card action inside of lib/src/ui/functions/note_card_functions and call it lock_note_action. Simply copy and paste the code in the pin_note_action. then update it to support locking the note, which is just simply changing the bool value. You can change the color of it to purple or green or something that stands out.
  5. Implement the new action into the note_card in the actions list parameter in the Slidable widget. (We don't want someone to be able to swipe all the way and lock it).

That should be it. This should work, but I obviously have no clue, and I don't have the time to implement it as of right now. I'm not sure if I went over everything so feel free to ask questions! I am also so sorry that I don't have clear guidelines for code implementations, and I had to describe it to you this way, but I hope this helps. Good Luck!

@31Carlton7 31Carlton7 added the enhancement New feature or request label Nov 14, 2021
@danger-ahead
Copy link
Contributor Author

danger-ahead commented Nov 14, 2021

  1. Add a new non nullable bool called locked to the note.dart model. This is located in lib/src/models/note.dart. Add that and update the rest of the parameters and methods to include it.

Actually I've already started working on this. I am trying to implement a global lock in the app.
This is what I plan to do:
screenshot

Should I discard this and work on the individual note locking instead?
We can later add that part too. As I've already coded out most of this feature.
Also I'm following your general code structure and not deviating from your design principles.

@danger-ahead danger-ahead mentioned this issue Nov 14, 2021
3 tasks
@31Carlton7
Copy link
Owner

The global lock feature is actually very creative. I didn't even think about that. Keep at it with that.

@danger-ahead
Copy link
Contributor Author

If you would like, you can email me a custom launcher icon in .png format and I'll update the app to include it, because I personally like to do it a certain way.

I've emailed you a custom launcher icon. Do let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants