Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON logging #154

Closed
janhoy opened this issue Oct 12, 2023 · 2 comments
Closed

JSON logging #154

janhoy opened this issue Oct 12, 2023 · 2 comments

Comments

@janhoy
Copy link
Contributor

janhoy commented Oct 12, 2023

Is your feature request related to a problem? Please describe.

More and more cloud native users request JSON-format structured logging which is easier to aggregate and parse by log collectors. There is a trend towards standardizing on this.

Describe the solution you'd like

I'd like it to be easy to enable JSON logging in Zookeeper docker image.

Describe alternatives you've considered

I have filed an issue in upstream Zookeeper project (https://issues.apache.org/jira/browse/ZOOKEEPER-4757). But the maintainers are reluctant to include the extra JARs and sample appender to make it happen.

Additional context

It is by far easier to include (and keep up to date) added jar dependencies in the upstream project than in a downstream Dockerfile. I hope you can chime in on the JIRA above and bring some perspective or suggest smarter solutions that will not require every single end user to build their own custom docker image.

@31z4
Copy link
Owner

31z4 commented Oct 18, 2023

I tend to turn down the idea of shipping additional jar files with the image in order to simplify JSON logging.

As discussed in the upstream issue it would required either:

  • a "crutch" to direct download from an mvnrepo or similar
  • or building a wrapper Maven project which contains the custom logback.xml and pulls the required dependencies.

First option is not reliable nor secure. Second option is out of scope for the Docker image packaging. IMO, the image itself should be as close to vanilla distribution as possible.

@janhoy
Copy link
Contributor Author

janhoy commented Oct 18, 2023

That's fair. If the goal of the image is to mimic upstream 1:1 then users must look elsewhere for a more production ready and feature rich image. Closing.

@janhoy janhoy closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants