Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced System Options is not setting the correct values for some Gameboy Colorization options. #538

Closed
Rolen47 opened this issue Jul 8, 2021 · 3 comments
Assignees

Comments

@Rolen47
Copy link

Rolen47 commented Jul 8, 2021

Describe the bug

The colorization option for "GBC" and "SGB" shouldn't be "internal" palette, Advanced System Options is setting them incorrectly.

To Reproduce

  1. Before choosing an original Gameboy game press the Select button and to go to Advanced System Options
  2. Colorization
  3. Select GBC or SGB.
  4. Load game (in my test I used Pokemon Blue)
  5. Check Colorization settings, they are wrong

Advanced System Options sets the following settings incorrectly:
GBC:
gambatte_gb_colorization = "internal"
gambatte_gb_internal_palette = "GBC"

SGB:
gambatte_gb_colorization = "internal"
gambatte_gb_internal_palette = "SGB"

Expected behavior

This is the correct settings that Advanced System Options should be setting for these options:
GBC:
gambatte_gb_colorization = "GBC"
gambatte_gb_internal_palette = ""

SGB:
gambatte_gb_colorization = "SGB"
gambatte_gb_internal_palette = ""

The rest of the colorization options appear to be functioning correctly because they are "Internal" colorization.

Device (please complete the following information):

RG351V with 351ELEC 20210603

@dhwz
Copy link
Member

dhwz commented Jul 8, 2021

@konsumschaf can you please check that

@konsumschaf
Copy link
Collaborator

Start working on this ...

@konsumschaf
Copy link
Collaborator

Fixed in #556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants