Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make retro changelog trim interval programmable #1037

Closed
389-ds-bot opened this issue Sep 12, 2020 · 9 comments
Closed

Make retro changelog trim interval programmable #1037

389-ds-bot opened this issue Sep 12, 2020 · 9 comments
Labels
closed: fixed Migration flag - Issue

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/47701


Currently, retro changelog trim interval is hardcoded with 5 minutes.
#define CHANGELOGDB_TRIM_INTERVAL 3001000 / 5 minutes

Better have a control on the interval based upon the DS usage -- e.g., if there is no updates, we don't need to call changelog_trim via retrocl_housekeeping every 5 minuges.

@389-ds-bot 389-ds-bot added the closed: fixed Migration flag - Issue label Sep 12, 2020
@389-ds-bot 389-ds-bot added this to the 1.3.3 - 2/14 (February) milestone Sep 12, 2020
@389-ds-bot
Copy link
Author

Comment from nhosoi (@nhosoi) at 2014-02-18 03:54:10

Description: Currently, retro changelog trim interval is hardcoded
with 5 minutes.
#define CHANGELOGDB_TRIM_INTERVAL 3001000 / 5 minutes

Better have a control on the interval based upon the DS usage --
e.g., if there is no updates, we don't need to call changelog_trim
via retrocl_housekeeping every 5 minutes.

@389-ds-bot
Copy link
Author

@389-ds-bot
Copy link
Author

Comment from nhosoi (@nhosoi) at 2014-02-19 01:24:16

Reviewed by Rich (Thank you!!)

Pushed to master:
98ddd81..bb4f0c4 master -> master
commit bb4f0c4

@389-ds-bot
Copy link
Author

Comment from nhosoi (@nhosoi) at 2014-02-19 03:36:52

git patch file (master) -- fixing syntax errors
0001-Ticket-47701-Make-retro-changelog-trim-interval-prog.2.patch

@389-ds-bot
Copy link
Author

Comment from nhosoi (@nhosoi) at 2014-02-19 03:38:05

Additional push for fixing compiler errors:
681be0d..b377d7d master -> master
commit b377d7d

@389-ds-bot
Copy link
Author

Comment from nhosoi (@nhosoi) at 2014-02-24 23:52:34

git patch file (master) -- Fixing "Coverity 12435 - Resource leak"
0001-Ticket-47701-Make-retro-changelog-trim-interval-prog.3.patch

@389-ds-bot
Copy link
Author

Comment from rmeggins (@richm) at 2014-02-25 00:06:25

ack

@389-ds-bot
Copy link
Author

Comment from nhosoi (@nhosoi) at 2014-02-25 00:17:44

Thank you for reviewing the change, Rich!

Pushed to master:
f7c5dc2..cd35419 master -> master
commit cd35419

@389-ds-bot
Copy link
Author

Comment from nhosoi (@nhosoi) at 2017-02-11 22:58:02

Metadata Update from @nhosoi:

  • Issue assigned to nhosoi
  • Issue set to the milestone: 1.3.3 - 2/14 (February)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant